[pull] main from coder:main #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On macOS this is checked by default for 2.5.0 and above.
Co-authored-by: GitHub Action <action@github.com>
We will need to put some new things in the top-level resources directory that are not SVGs, so this hopefully makes the structure clearer.
Bumps [org.apache.groovy:groovy-bom](https://github.com/apache/groovy) from 4.0.17 to 4.0.19. - [Commits](https://github.com/apache/groovy/commits) --- updated-dependencies: - dependency-name: org.apache.groovy:groovy-bom dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The main goal was the ability to use steps separately. We may only need the IDE selection step when handling a link, for example. Each step now takes a specific type of data (if it needs some) then returns a specific type of data. The way to tell if a step is ready to return data is via a callback you pass into the step. I think more improvements will become apparent once we start using it in the link handler.
This was deleted a while back but I did not update the plugin.xml.
Otherwise they will not surface to the user (as an error bubble at the bottom).
The previous refactor was close but we needed a bit more refactoring to make a single step usable on its own, as it will be used in the link handler. The main problem was the wrapper that had both steps in it, we would have to pass in the steps instead which brings us back to that whole generalization problem where a step has types that lead into the next step's init. The solution is to remove the wrapper and wire up the steps wherever they are needed, whether that is one step or multiple, and the main change to make that possible is to move the buttons into each step rather than having them in a wrapper component. Now you can create any single step and use its output. This is used in the link flow and the buttons in the step now replace the default buttons in the dialog wrapper.
I am not sure why this was behind invokeLater.
Co-authored-by: GitHub Action <action@github.com>
The issue I am having with Gson is that it relies on some unsafe thing that is not available in all cases. Since Moshi is by the same folks that wrote the HTTP and REST clients we are using, it seemed like the best replacement. Thankfully, for the most part this was a simple search and replace, but calling toJson and fromJson is a bit more burdensome as you have to call `adapter` and include the type, and it has no built-in converter for UUID. On the flip side, the converters require slightly less code.
Many of these are out of date, and it seems Moshi is more strict about parsing because when a property is missing it will error. For now, pare down the SDK to just the values we are using, but ideally we would generate this from coder/coder itself.
This is supposed to be faster than using reflection.
Bumps [org.jetbrains.kotlin.jvm](https://github.com/JetBrains/kotlin) from 1.9.22 to 1.9.23. - [Release notes](https://github.com/JetBrains/kotlin/releases) - [Changelog](https://github.com/JetBrains/kotlin/blob/v1.9.23/ChangeLog.md) - [Commits](JetBrains/kotlin@v1.9.22...v1.9.23) --- updated-dependencies: - dependency-name: org.jetbrains.kotlin.jvm dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@v4.1.1...v4.1.2) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
The REST client is not really a service in the same way, but it feels to me like it matches well enough. Naming it like this resolves some weirdness when using the client in other contexts (where you would use the base client directly).
Replace the REST-API-based start flow with one that shells out to the coder CLI. This is the JetBrains extension equivalent to coder/vscode-coder#400.
Co-authored-by: GitHub Action <action@github.com>
Co-authored-by: GitHub Action <action@github.com>
defaultIde selection setting
Co-authored-by: GitHub Action <action@github.com>
* Add "Check for IDE updates" setting This setting controls whether the plugin checks for available backend IDE upgrades (on by default). Turning it off suppresses the prompt to upgrade to a newer version. * Add "Check for IDE updates" setting to CHANGELOG.md
Co-authored-by: GitHub Action <action@github.com>
* Use wildcard SSH config Host entries This simplifies the written SSH config and avoids the need to make an API request for every workspace the filter returns. This can remove minutes from the "Configuring Coder CLI..." step when the user has access to many workspaces (for example, an admin who wants the option of connecting to anyone's workspace on a large deployment). Depends on coder/coder#16088 * changelog update --------- Co-authored-by: Benjamin Peinhardt <61021968+bcpeinhardt@users.noreply.github.com> Co-authored-by: Benjamin <benjaminpeinhardt@gmail.com>
Co-authored-by: GitHub Action <action@github.com>
* Update version. * Update changelog
Co-authored-by: GitHub Action <action@github.com>
#539) prevent unintended early return from skipping writing wildcard configs
* setup script can communicate an error message to the end user * review fixes * custom exception class for setup command * better title * changelog update --------- Co-authored-by: Benjamin Peinhardt <61021968+bcpeinhardt@users.noreply.github.com> Co-authored-by: Benjamin <benjaminpeinhardt@gmail.com>
Co-authored-by: GitHub Action <action@github.com>
…ature (#542) * Retrieve workspace directly in link handler when using wildcardSSH feature Instead of listing all workspaces matching the filter, get info about the specific workspace the user is trying to connect to. This lets jetbrains-gateway:// links to others' workspaces work without needing to modify the workspace filter parameter. * changelog update --------- Co-authored-by: Benjamin Peinhardt <61021968+bcpeinhardt@users.noreply.github.com> Co-authored-by: Benjamin <benjaminpeinhardt@gmail.com>
… they are superseded (#548) * chore: build and test with newer Gateway version The existing EAP snapshot was removed from the repo * fix: skip installed EAP, RC, NIGHTLY and PREVIEW ides from showing if they are superseded The IDE and Project view will no longer show IDEs that are installed and which are not yet released, but they have a released version available for download. * impl: add UTs for installed IDEs filtering
* chore: use newer snapshot build for testing and building I've also changed the list of Gateway versions we run the verifier against to include Gateway 2025.1 while excluding some ancient releases. Without this commit the PR will fail to build, the declared snapshots are no longer available in the repository * fix: pass the folder parameter to the IDE&Project dialog The value of the `folder` URI parameter is passed to the IDE&Project dialog when handling URIs. The folder value will be rendered instead of the default home folder if the value is not blank. -resolves #466 * chore: next version is 2.20.1
* chore: upgrade Gradle to 8.5 the latest version This upgrade is needed in order to be able to upgrade the gateway/intellij platform plugins. * chore: upgrade Gradle IntelliJ Plugin This is needed in order to be able to specify "unlimited until builds". IntelliJ Platform Gradle Plugin 2.x is the build system that supersedes the Gradle IntelliJ Plugin 1.x, and this is the version that comes with the ability to provide unlimited until build support. This is a major overhaul of the DSL, I've tested these changes locally with GW 2023.3 (the minimum supported version), and I've also compared the plugin.xml with a previous version to make sure it is generated correctly. * impl: support for unlimited 'Until Build' setting Every time a new GW version is released we need to change the untilBuild setting. With latest IntelliJ Platform Plugin we can provide unlimited upper range with no manual intervention each time a new release is happening. * chore: simplify build script Use gateway DSL to provide the platform type and version. The plugin verification as well as the platform type depends on the versions in the format "2025.x" * fix: merge from main was botched * fix: missing junit4 dependency for IntelliJ test framework We don't have any UI tests but the test task still fails because it misses junit 4 dependencies. For the unit tests we use kotlin tests library with junit 5 as a backend. * fix: task was renamed listProductsReleases was renamed to printProductsReleases in version 2.x * chore: use latest version 2.6.0 for the platform plugin
* impl: update icons to match the new branding * fix: eap build is no longer available for verification In the previous PR 2025.2 EAP build was available on the default repositories, it no longer seems the case. Additionally, I've configured the verification phase to use the latest available 2024.3 patch (6 patches available) * chore: next version is 2.21.0
* fix: marketplace logos should use the new design # Conflicts: # CHANGELOG.md * chore: next version should be 2.21.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )