8000 [Twig] Brace insert handler for function · Issue #864 · Haehnchen/idea-php-symfony2-plugin · GitHub
[go: up one dir, main page]
Skip to content

[Twig] Brace insert handler for function #864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Haehnchen opened this issue Feb 5, 2017 · 0 comments
Closed

[Twig] Brace insert handler for function #864

Haehnchen opened this issue Feb 5, 2017 · 0 comments
Labels
fixed

Comments

@Haehnchen
Copy link
Owner
Haehnchen commented Feb 5, 2017 •
edited
Loading 
{{ asset }} -> {{ asset(<caret>) }}
{{ form }} -> {{ form(<caret>) }}
{{ path() }} -> {{ path('<caret>') }}
Haehnchen added a commit that referenced this issue Feb 5, 2017
@Haehnchen
add brace insert handler for Twig functions with string parameter det…
95dbab1 
…ection #864
@Haehnchen Haehnchen mentioned this issue Feb 5, 2017
Merged
Haehnchen added a commit that referenced this issue Feb 5, 2017
@Haehnchen
fix test case for newly added Twig function insert handler #864
4297daf
@Haehnchen Haehnchen added the fixed label Feb 5, 2017
fabpot added a commit to symfony/symfony that referenced this issue Feb 16, 2017
@fabpot
minor #21536 [TwigBridge] Add docblocks for Twig url and path functio…
85ae59a 
…n to improve ide completion (Haehnchen)

This PR was merged into the 2.7 branch.

Discussion
----------

[TwigBridge] Add docblocks for Twig url and path function to improve ide completion

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

`RoutingExtension` missed docblock for Twig extension so `path` and `url` are not fully recognized by PhpStorm.

Haehnchen/idea-php-symfony2-plugin#864 will add more smarter completion
`{{ p<caret> }} -> {{ path('<caret>') }}`, but string parameter is not detected. This will add the minimal docs

Commits
-------

93ab017 add docblocks for Twig url and path function to improve ide completion
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Haehnchen
0