Resize: BUGFIX on attachedToNode and on clone#2
Open
Pankovea wants to merge 3 commits intoHAG87:masterfrom
Open
Resize: BUGFIX on attachedToNode and on clone#2Pankovea wants to merge 3 commits intoHAG87:masterfrom
Pankovea wants to merge 3 commits intoHAG87:masterfrom
Conversation
Author
|
On 1 december i was finished refactoring the resizer script. All commets in commit message. The script started working faster. |
b331d6a to
c142246
Compare
Author
|
There are some little corrections in these forced pushes |
The functionality is organized so that point scaling operations are performed once. The interface is disconnected from parameter changes. Features added to the interface: * Entering dimensions based on scaling. That is, on a scaled object, we set the actual size in global units. * Convert to Xform - to store information about them from one of the users * Convert to Transform - removes the modifier and transforms the transformations of the object. At the same time, if there are modifiers above, then their modifier context will be changed to save the modification result. Emerging issues: When Converting To Transform, when executing commands line by line in Listener, the result corresponds to the original one. But when executed in a script, the result is different. It is not yet possible to find out what the reason is.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in BUMP_resize.ms
While I was trying to find the error by simply using print in the
getLimitsfunction, the behavior of the modifier when added became expected. As a result, I just added a reference to the object and the error in the calculations went away.In the line
on x_mount set val do ...there is no need to check if the modifier has just been loaded. Updating the values ofx_amountand othernewDimswill always change.During cloning, the state is stored in is_cloned. Then, no changes are made to
attachedToNodeafter cloning.Now Everything is is working as expected.