Round score to the first decimal #9105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anyway, and the way it is truncated in the frontend can lead to the wrong value displayed (0.8 instead of 0.9 for a value of 0.89999999)
Sita04
approved these changes
Feb 9, 2023
Sita04
added a commit
that referenced
this pull request
Feb 21, 2023
* docs(recaptcha-samples): init add demosite * Update docker-compose.yaml * Update docker-compose.yaml * Change default port from 8000 to 8080. (#9043) * Change default port from 8000 to 8080. * Add Apache license to docker-compose.yaml * feat(demosite): add gamified demosite (#8857) * feat: update demosite pages and theme - Updates demosite pages to add examples - Updates visual design and layout of examples Still work in progress: - Visual design - Layout - Interaction design - Copy - Replace checkbox examples - Add game * feat: update app urls * add license headers Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com> * refactored to remove comments and print statements * Demosite app recaptcha (#9068) * chore: cleanup todos * feat: cleanup checkboxes and draft copy * chore: fix simple example, animate results, game placeholder * chore: correct checkbox keys and add game route * moved context to global --------- Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com> * removed checkbox references from dockerfile * refactor create assessment call * fix score display issue * refactor to demonstrate site_key best practice * Round score to the first decimal; scores never have a second decimal anyway, and the way it is truncated in the frontend can lead to the wrong value displayed (0.8 instead of 0.9 for a value of 0.89999999) (#9105) * add headers * lint fix * lint * fix typo * added newline * Add an optional DOCKER_COMPOSE_USER environment variable. This can be helpful such that files get created by the same user that is running docker (#9130) * updated README and verdict in assessment. Added comment in dockerfiles --------- Co-authored-by: Cory Kramer <corykramer@google.com> Co-authored-by: Rhy Moore <git@morewry.me> Co-authored-by: Francois Aube <faube@google.com> Co-authored-by: nicain <nicholascain@google.com>
telpirion
pushed a commit
that referenced
this pull request
Mar 13, 2023
* docs(recaptcha-samples): init add demosite * Update docker-compose.yaml * Update docker-compose.yaml * Change default port from 8000 to 8080. (#9043) * Change default port from 8000 to 8080. * Add Apache license to docker-compose.yaml * feat(demosite): add gamified demosite (#8857) * feat: update demosite pages and theme - Updates demosite pages to add examples - Updates visual design and layout of examples Still work in progress: - Visual design - Layout - Interaction design - Copy - Replace checkbox examples - Add game * feat: update app urls * add license headers Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com> * refactored to remove comments and print statements * Demosite app recaptcha (#9068) * chore: cleanup todos * feat: cleanup checkboxes and draft copy * chore: fix simple example, animate results, game placeholder * chore: correct checkbox keys and add game route * moved context to global --------- Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com> * removed checkbox references from dockerfile * refactor create assessment call * fix score display issue * refactor to demonstrate site_key best practice * Round score to the first decimal; scores never have a second decimal anyway, and the way it is truncated in the frontend can lead to the wrong value displayed (0.8 instead of 0.9 for a value of 0.89999999) (#9105) * add headers * lint fix * lint * fix typo * added newline * Add an optional DOCKER_COMPOSE_USER environment variable. This can be helpful such that files get created by the same user that is running docker (#9130) * updated README and verdict in assessment. Added comment in dockerfiles --------- Co-authored-by: Cory Kramer <corykramer@google.com> Co-authored-by: Rhy Moore <git@morewry.me> Co-authored-by: Francois Aube <faube@google.com> Co-authored-by: nicain <nicholascain@google.com>
Sita04
pushed a commit
that referenced
this pull request
Mar 14, 2023
…anyway, and the way it is truncated in the frontend can lead to the wrong value displayed (0.8 instead of 0.9 for a value of 0.89999999) (#9105)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Round score to the first decimal. Scores never have a second decimal anyway, and the way it is truncated in the frontend can lead to the wrong value displayed (0.8 instead of 0.9 for a value of 0.89999999)
Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)