8000 docs(auth-samples): add API Key auth samples and tests by Sita04 · Pull Request #8455 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]

Skip to content

docs(auth-samples): add API Key auth samples and tests #8455 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Dec 5, 2022
Merged

Conversation

Sita04
Copy link
Collaborator
@Sita04 Sita04 commented Nov 3, 2022

Added samples and tests for API key samples.

@Si
8000
ta04 Sita04 requested review from arithmetic1728 and a team as code owners November 3, 2022 14:14
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 3, 2022
@snippet-bot
Copy link
snippet-bot bot commented Nov 3, 2022

Here is the summary of changes.

You are about to add 9 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

8000
@Sita04 Sita04 requested a review from dandhlee November 15, 2022 20:18
"""

# Initialize the Language Service client and set the API key and the quota project id.
client = language_v1.LanguageServiceClient(client_options={"api_key": api_key_string,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api_key client option won't work until googleapis/google-auth-library-python#1184 is released

@@ -1,3 +1,7 @@
google-api-python-client==2.47.0
google-auth-httplib2==0.1.0
google-auth==2.6.2
google-auth==2.11.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update google-auth after googleapis/google-auth-library-python#1184 is released

Copy link
Collaborator
@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending updated based on Sijun's comment.

@dandhlee dandhlee added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Nov 16, 2022
@Sita04 Sita04 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Dec 5, 2022
@Sita04
Copy link
Collaborator Author
Sita04 commented Dec 5, 2022

googleapis/google-auth-library-python#1184 released. Hence merging this PR.

@Sita04 Sita04 merged commit a23bcef into main Dec 5, 2022
@Sita04 Sita04 deleted the samples-api-key branch December 5, 2022 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0