8000 Rename clear file system dag by leahecole · Pull Request #7155 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]

Skip to content

Rename clear file system dag #7155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 24, 2021
Merged

Conversation

leahecole
Copy link
Collaborator
@leahecole leahecole commented Nov 23, 2021

Description

Fixes b/202996058

This DAG is only for usage in Composer v1 and we will not have a corresponding one in Composer v2 - I did some renaming to ensure if you add it to your environment it's very visible it's for Composer v1

Note: It's a good idea to open an issue first for discussion.

Checklist

@leahecole leahecole requested review from rachael-ds and a team as code owners November 23, 2021 18:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 23, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 23, 2021
Copy link
Contributor
@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: consider "composer_v1" for extra clarify that this refers to the version, not just the first step of something

@leahecole
Copy link
Collaborator Author
leahecole commented Nov 23, 2021

nit: consider "composer_v1" for extra clarify that this refers to the version, not just the first step of something

Which one of these are you referring to?

Edit figured it out you mean filename. That's totally fine, happy to make that change!

Copy link
Contributor
@rachael-ds rachael-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Nov 24, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 90a0221 into master Nov 24, 2021
< 8000 /div>
@gcf-merge-on-green gcf-merge-on-green bot deleted the mark-composer-1-sample branch November 24, 2021 18:06
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0