8000 Add region tags for the Composer 2 Airflow REST API example by pavel-salnikov · Pull Request #7151 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Add region tags for the Composer 2 Airflow REST API example #7151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 22, 2021
Merged

Add region tags for the Composer 2 Airflow REST API example #7151

merged 2 commits into from
Nov 22, 2021

Conversation

pavel-salnikov
Copy link
Contributor
@pavel-salnikov pavel-salnikov commented Nov 22, 2021 •
edited
Loading

Description

Add region tags, so that this example can be used on a different documentation page.

Checklist

@snippet-bot
Copy link
snippet-bot bot commented Nov 22, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 22, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 22, 2021
nicain
nicain reviewed Nov 22, 2021
View reviewed changes
composer/rest/composer2/composer2_airflow_rest_api.py
@@ -18,6 +18,7 @@
"""

# [START composer_2_trigger_dag]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to delete this?

Copy link
Collaborator
@leahecole leahecole Nov 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope - they're nested on purpose I believe - @pavel-salnikov

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, they're nested on purpose. Thanks!

@leahecole leahecole merged commit 2793b88 into GoogleCloudPlatform:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicain nicain nicain left review comments

@leahecole leahecole leahecole approved these changes

@tswast tswast tswast approved these changes

@rachael-ds rachael-ds Awaiting requested review from rachael-ds

Assignees

@loferris loferris

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pavel-salnikov @nicain @tswast @leahecole @loferris
0