8000 Fix `tempLocation` Dataflow parameter in Airflow example by lcaggio · Pull Request #7139 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Fix tempLocation Dataflow parameter in Airflow example #7139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2021
Merged

Fix tempLocation Dataflow parameter in Airflow example #7139

merged 4 commits into from
Nov 22, 2021

Conversation

lcaggio
Copy link
Contributor
@lcaggio lcaggio commented Nov 19, 2021

Fix tempLocation parameter as per Airflow documentation at https://airflow.apache.org/docs/apache-airflow-providers-google/stable/_api/airflow/providers/google/cloud/operators/dataflow/index.html

Description

Fixes #7138

Note: It's a good idea to open an issue first for discussion.

Checklist

@lcaggio lcaggio requested review from leahecole, rachael-ds and a team as code owners November 19, 2021 15:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 19, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 19, 2021
@leahecole leahecole changed the title Fix tempLocation Dataflow parameter Fix tempLocation Dataflow parameter in Airflow example Nov 19, 2021
@engelke engelke added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@leahecole
Copy link
Collaborator

Thank you! Can you update the Airflow 2 sample as well?

python-docs-samples/composer/workflows/dataflowtemplateoperator_tutorial.py

Line 51 in 2038be9

"temp_location": bucket_path + "/tmp/",

@leahecole leahecole assigned lcaggio and unassigned engelke Nov 19, 2021
@lcaggio lcaggio removed their assignment Nov 19, 2021
@leahecole leahecole self-assigned this Nov 19, 2021
@leahecole leahecole added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 19, 2021
@busunkim96
Copy link
Contributor

Gentle reminder to please review/merge this in the next 2-3 days before the issue goes OOSLO. Thank you!

rachael-ds
rachael-ds approved these changes Nov 22, 2021
View reviewed changes
Copy link
Contributor
@rachael-ds rachael-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked against the source code ... LGTM, thanks!

@leahecole leahecole added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. and removed automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Nov 22, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 22, 2021
@leahecole leahecole merged commit cdd2395 into GoogleCloudPlatform:master Nov 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole approved these changes

@rachael-ds rachael-ds rachael-ds approved these changes

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix tempLocation Dataflow parameter in the Composer dataflowtemplateoperator tutorial
6 participants
@lcaggio @leahecole @busunkim96 @rachael-ds @engelke @kokoro-team
0