Add a sleep for the service account to propagate. #6895
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a2ee586 to
389a855
Compare
|
I'll run the tests a couple of time to see if they keep failing. |
busunkim96
reviewed
Oct 11, 2021
I suspect that sometimes this method fails because there is a race condition when creating the new servie account. Adding a service account is not a LRO, but it's also no atomic. The information about the new account needs a moment to propagate through the system. Closes #6894
0bd680e to
9f3e64c
Compare
|
Copyright header fixed. |
busunkim96
approved these changes
Oct 12, 2021
dandhlee
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect that sometimes this method fails
because there is a race condition when creating the new
servie account. Adding a service account is not a LRO,
but it's also no atomic. The information about the new
account needs a moment to propagate through the system.
Closes #6894
Description
Fixes #
Note: It's a good idea to open an issue first for discussion.
Checklist
nox -s py-3.6(see Test Environment Setup)nox -s lint(see Test Environment Setup)