8000 Use requirements.txt instead of hard-coded install by engelke · Pull Request #6560 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Use requirements.txt instead of hard-coded install #6560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 13, 2021
Merged

Use requirements.txt instead of hard-coded install #6560

merged 3 commits into from
Aug 13, 2021

Conversation

engelke
Copy link
Contributor
@engelke engelke commented Aug 13, 2021

Addresses issue #6559

Description

Fixes #

Note: It's a good idea to open an issue first for discussion.

Checklist

@engelke engelke requested a review from a team as a code owner August 13, 2021 00:14
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Aug 13, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 13, 2021
@engelke engelke linked an issue Aug 13, 2021 that may be closed by this pull request
run/helloworld does not use requirements.txt file #6559
Closed
dandhlee
dandhlee approved these changes Aug 13, 2021
View reviewed changes
Copy link
Collaborator
@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like they may have been hardcoded before for the sake of region tags, but I think it's fine to only say "install dependency with requirements.txt".

leahecole
leahecole previously requested changes Aug 13, 2021
View reviewed changes
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
@leahecole leahecole dismissed their stale review August 13, 2021 17:35

i made the change I requested because it was small

@leahecole leahecole merged commit 2ecc840 into master Aug 13, 2021
@leahecole leahecole deleted the engelke-patch-1 branch August 13, 2021 17:35
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@averikitsch averikitsch averikitsch approved these changes

@dandhlee dandhlee dandhlee approved these changes

@leahecole leahecole leahecole left review comments

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

run/helloworld does not use requirements.txt file
4 participants
@engelke @averikitsch @leahecole @dandhlee
0