Copy Endpoints Python Echo sample to a new location. #631
Conversation
… new home, once we clean up the docs.
| @@ -0,0 +1,12 @@ | |||
| FROM debian:jessie | |||
There was a problem hiding this comment.
Why not just use gcr.io/google_appengine/python - it's designed to work on GKE as well.
There was a problem hiding this comment.
Turns out we don't actually need this Dockerfile. Removed, in a following commit.
|
Why remove the dockerfile? Isn't that needed? |
|
Turns out this isn't needed by any of our current samples. It'd only be I'm double checking that with our team, to make sure no upcoming changes On Wed, Nov 2, 2016 at 3:26 PM, Jon Wayne Parrott notifications@github.com
|
|
@kdeus would you not want to tell users how to create their own docker image? |
|
Yes, we'll want to do that. But it sounds like we're going to use a On Wed, Nov 2, 2016 at 3:40 PM, Jon Wayne Parrott notifications@github.com
|
|
It seems weird to have that separate from the source code that'll live in the container, no? |
|
We won't be using this source code to build a docker image. We'll use a On Wed, Nov 2, 2016 at 3:42 PM, Jon Wayne Parrott notifications@github.com
|
|
Then what's the point of having any GKE stuff here? On Wed, Nov 2, 2016, 3:45 PM kdeus notifications@github.com wrote:
|
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http: // www.apache.org/licenses/LICENSE-2.0 |
There was a problem hiding this comment.
Dunno what happened here but this URL is borked.
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http: // www.apache.org/licenses/LICENSE-2.0 |
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http: // www.apache.org/licenses/LICENSE-2.0 |
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http: // www.apache.org/licenses/LICENSE-2.0 |
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http: // www.apache.org/licenses/LICENSE-2.0 |
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http: // www.apache.org/licenses/LICENSE-2.0 |
|
My point is that why have that stuff here if it does not pertain to this On Wed, Nov 2, 2016, 4:59 PM kdeus notifications@github.com wrote: @kdeus commented on this pull request. The GKE stuff is used by examples showing how Google Cloud Endpoints works app.yaml is there: to show how this works for GAE.In endpoints/echo/clients/service_to_service_gae_default/main.py
FixedIn endpoints/echo/clients/service_to_service_google_id_token/main.py
DoneIn endpoints/echo/clients/service_to_service_non_default/main.py
Done — Reply to this email directly, view it on GitHub |
|
We've been debating that. :) The intent here is that if someone comes in wanting to know how to use There will be more in-depth tutorials that include steps such as building a This PR isn't really changing anything about the content of the sample. On Wed, Nov 2, 2016 at 5:03 PM, Jon Wayne Parrott notifications@github.com
|
|
So my question is this: What's the point of duplicating the gke.yaml config from the endpoints-samples repository here if this source code is not used for that sample? In fact, no source code is used for that sample. In my opinion adding the Why can't we just leave the /cc @jeffmendoza |
|
Agree with Jon here. We need the Dockerfile, even if the quickstart does not document how to build the code into a docker container. Also, the gke and gce+docker quickstarts should use the docker image built from the code in this repo. Same for all the languages. |
| name: nginx-ssl | ||
| readOnly: true | ||
| - name: echo | ||
| image: b.gcr.io/endpoints/echo:latest |
There was a problem hiding this comment.
Needs to point to an image of this code.
There was a problem hiding this comment.
built and pushed gcr.io/google-samples/echo-python:1.0
|
The Dockerfile is back (as Dockerfile.custom). Also, I've partially stripped the Readme, removing references to GAE and anything that's duplicated in our Quickstarts. We don't yet have a tutorial describing how to use the client libraries in this sample, so I'm leaving that information in until we create those tutorials. |
|
Updated gke.yaml to point to the new image. On Thu, Nov 3, 2016 at 10:43 AM, Jeff Mendoza notifications@github.com
|
|
Please use On Thu, Nov 3, 2016 at 10:47 AM kdeus notifications@github.com wrote:
|
|
Renamed to container-engine.yaml. On Thu, Nov 3, 2016 at 10:48 AM, Jon Wayne Parrott <notifications@github.com
|
This will be its new home, once we clean up the docs.
This sample is used for multiple platforms, and hiding it under appengine/flex is confusing.