10000 docs: clarified reference to project parameter by craiglabenz · Pull Request #6280 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

docs: clarified reference to project parameter #6280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 14, 2021
Merged

docs: clarified reference to project parameter #6280

merged 7 commits into from
Jul 14, 2021

Conversation

craiglabenz
Copy link
Contributor

Region tags firestore_setup_client_create and firestore_setup_client_create_with_project_id are being consolidated. The latter was never a thing in the Python samples, but here we keep what Python samples that do exist in line with the target state for all 7 languages (1 snippet that explains the optional parameter).

@craiglabenz craiglabenz requested review from a team as code owners July 9, 2021 20:00
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jul 9, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 9, 2021
crwilcox
crwilcox reviewed Jul 12, 2021
View reviewed changes
@craiglabenz
Copy link
Contributor Author

Like Sisyphus, I appear doomed to merge master into this branch for the rest of time.

@craiglabenz craiglabenz added the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2021
@leahecole
Copy link
Collaborator

Like Sisyphus, I appear doomed to merge master into this branch for the rest of time.

Gotta get two approvals in this repo! @crwilcox or @kolea2 should be your number 2

@leahecole leahecole removed the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2021
kolea2
kolea2 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor
@kolea2 kolea2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@kolea2
Copy link
Contributor
kolea2 commented Jul 14, 2021

@googlebot

@dandhlee dandhlee merged commit 6bac124 into master Jul 14, 2021
@dandhlee dandhlee deleted the firestore-client-project-id branch July 14, 2021 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox crwilcox left review comments

@leahecole leahecole leahecole approved these changes

@kolea2 kolea2 kolea2 approved these changes

Assignees

@leahecole leahecole

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@craiglabenz @leahecole @kolea2 @crwilcox @dandhlee
0