-
Notifications
You must be signed in to change notification settings - Fork 6.5k
Added tox config with flake8 and nosetests. #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@elibixby I'd appreciate it if you could take a look. |
@@ -1,6 +1,6 @@ | |||
# dummy app.yaml for nosegae | |||
|
|||
application: ndb-snippets | |||
application: python-docs-samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
application and version field are supposed to be deprecated yes? Could we move these to env vars?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, we don't need those values
Thanks, PTAL |
All reactions
Sorry, something went wrong.
[run] | ||
include = | ||
datastore/* | ||
localtesting/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging #2 So please add bigquery/
Sorry, something went wrong.
All reactions
Besides comment LGTM |
All reactions
Sorry, something went wrong.
Well, this time I'm going to add bigquery, but it shows 100 lines of flake8 errors (and I need to fix them). |
All reactions
Sorry, something went wrong.
Yeah Sorry! That's weird I ran flake on it right before merging and it was fine! (oh except I ran the licensing tool after that, I bet those 100 lines of errors are in the licenses...) |
All reactions
Sorry, something went wrong.
Yes, turns out that it's not a big problem |
All reactions
Sorry, something went wrong.
Ugh, that's not limited to licenses. Anyways, I'll try to fix them |
All reactions
Sorry, something went wrong.
Ok, the tests are all green when run locally. |
All reactions
Sorry, something went wrong.
Might have to wait until after the weekend... =/ Travis builds have been super slow to start lately. |
All reactions
Sorry, something went wrong.
Changes Unknown when pulling ac005e7 on tox into * on master*. |
All reactions
Sorry, something went wrong.
All green :) |
All reactions
Sorry, something went wrong.
@elibixby |
All reactions
Sorry, something went wrong.
Sorry! Was on vacation! LGTM, merge away. |
All reactions
Sorry, something went wrong.
No worries. Thanks for looking! |
All reactions
Sorry, something went wrong.
Added tox config with flake8 and nosetests.
## Description #7342 introduced a change where nox would check for `test_*.py` and `*_test.py` files. Django and IDP-SQL had their tests in `test/`, so this glob didn't find these files, and these tests haven't been run for a bit. Outstanding issues with these tests: *dynamic PR status update follows* --- * Django: Postgres 9.6 EOL ``` Step #6 - "Migrate database": django.db.utils.ProgrammingError: column c.relispartition does not exist Step #6 - "Migrate database": LINE 3: CASE WHEN c.relispartition THEN 'p' WHEN c.relki... Step #6 - "Migrate database": ``` Debugging seems to indicate this happens on old versions of postgres. [Django 4.0 no longer supports Postgres 9.6](https://docs.djangoproject.com/en/4.0/releases/4.0/#dropped-support-for-postgresql-9-6). `test-instance-pg` is Postgres 9.6, which is EOL as of November 2021. Suggest creating a newer versioned instance of a postgres testing database (happy to help here where I can). Update: test-instance-pg has been updated to Postgres 14 --- * IDP: Linting issues ``` ./middleware.py:31:29: ANN401 Dynamically typed expressions (typing.Any) are disallowed def decorated_function(*args: Any, **kwargs: Any) -> Any: ^ ./middleware.py:31:42: ANN401 Dynamically typed expressions (typing.Any) are disallowed def decorated_function(*args: Any, **kwargs: Any) -> Any: ^ ./middleware.py:31:61: ANN401 Dynamically typed expressions (typing.Any) are disallowed def decorated_function(*args: Any, **kwargs: Any) -> Any: ^ ``` This is being addressed as of v2.9.0 of flake8-annotations. sco1/flake8-annotations#136 It will require adding `--allow-star-arg-any` to the flake8 call. Update: while this flag could be used, I opted to use the `TypeVar` method in #7789 --- ## Checklist - [ ] I have followed [Sample Guidelines from AUTHORING_GUIDE.MD](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md) - [ ] README is updated to include [all relevant information](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#readme-file) - [ ] **Tests** pass: `nox -s py-3.6` (see [Test Environment Setup](https://github.com/Goog 6B21 leCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] **Lint** pass: `nox -s lint` (see [Test Environment Setup](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/AUTHORING_GUIDE.md#test-environment-setup)) - [ ] These samples need a new **API enabled** in testing projects to pass (let us know which ones) - [ ] These samples need a new/updated **env vars** in testing projects set to pass (let us know which ones) - [ ] Please **merge** this PR for me once it is approved. - [ ] This sample adds a new sample directory, and I updated the [CODEOWNERS file](https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/.github/CODEOWNERS) with the codeowners for this sample
Successfully merging this pull request may close these issues.
No description provided.