10000 Add test for firetactoe. by jerjou · Pull Request #594 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Add test for firetactoe. #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 20, 2016
Merged

Add test for firetactoe. #594

merged 3 commits into from
Oct 20, 2016

Conversation

jerjou
Copy link
Contributor
@jerjou jerjou commented Oct 19, 2016

No description provided.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 19, 2016
theacodes
theacodes approved these changes Oct 19, 2016
View reviewed changes
appengine/standard/firebase/firetactoe/firetactoe_test.py
self.request_url = None

def __call__(self, *args, **kwargs):
self.constructor_args = (args, kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be used, remove it?

@jerjou
Copy link
Contributor Author
jerjou commented Oct 19, 2016

@dpebot would you mind merging when travis approves?

@jerjou jerjou added the automerge Merge the pull request once unit tests and other checks pass. label Oct 19, 2016
@jerjou
Copy link
Contributor Author
jerjou commented Oct 20, 2016

FYI added a commit to fix the style errors that are breaking the build.

Remove rest_api.py, which may be obsolete.
14668cc 
The doc that depends on this is undergoing a rewrite that obviates the need for
this file. Plus, checking for "null" seems unnecessary, and there are a bunch of
style things that aren't passing our linter.
@jerjou
Copy link
Contributor Author
jerjou commented Oct 20, 2016

FYI removed a file that also had style errors (and a dubious null check). Also, a rewrite of the doc that uses it may make the file obsolete (so not worth trying to fix it). If it turns out to still be needed, we can open another PR to re-add it.

@jerjou jerjou merged commit ba53d37 into master Oct 20, 2016
@jerjou jerjou deleted the firetest branch October 20, 2016 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jerjou @theacodes @googlebot
0