8000 Update dag test utils for Airflow 2.0 by leahecole · Pull Request #5865 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Update dag test utils for Airflow 2.0 #5865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 24, 2021
Merged

Update dag test utils for Airflow 2.0 #5865

merged 7 commits into from
May 24, 2021

Conversation

leahecole
Copy link
Collaborator
@leahecole leahecole commented May 21, 2021 •
edited
Loading

Description

To test this locally, follow the instructions in the maintenance guide (MAINTAINING.md introduced in this PR) for "how to test the distribution locally", but you'll also have to...

  1. Update the version of Airflow to 2.0.0 in workflows/requirements.txt
  2. Remove the rbac=None from the resetdb command in composer/conftest.py

The tests in workflows will actually NOT all pass, but this is expected! Those test failures are fixed in #5782

I have pushed this (under a different version number) to TestPyPI so you can see that the README logic to the setup.py works

Blocked by #5860
Note: It's a good idea to open an issue first for discussion.

Checklist

@snippet-bot
Copy link
snippet-bot bot commented May 21, 2021

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label May 21, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2021
@leahecole leahecole changed the title Add changelog and maintenance guide Update dag test utils for Airflow 2.0 May 21, 2021
@leahecole leahecole added the status: blocked Resolving the issue is dependent on other work. label May 21, 2021
@leahecole leahecole mentioned this pull request May 21, 2021
Merged
8 tasks
@leahecole leahecole marked this pull request as ready for review 8000 May 21, 2021 05:42
@leahecole leahecole requested a review from a team as a code owner May 21, 2021 05:42
@leahecole leahecole added the blunderbuss: assign Instruct blunderbuss to assign someone label May 21, 2021
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label May 21, 2021
rachael-ds
rachael-ds approved these changes May 21, 2021
View reviewed changes
Copy link
Contributor
@rachael-ds rachael-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade and explainer files look great - one minor comment from my side!

@leahecole leahecole removed the status: blocked Resolving the issue is dependent on other work. label May 21, 2021
shollyman
shollyman approved these changes May 24, 2021
View reviewed changes
@leahecole leahecole assigned crwilcox and busunkim96 and unassigned engelke May 24, 2021
@leahecole leahecole requested a review from busunkim96 May 24, 2021 20:32
@leahecole leahecole merged commit 61b3851 into master May 24, 2021
@leahecole leahecole deleted the new-dag-utils-versison branch May 24, 2021 20:59
@leahecole
Copy link
Collaborator Author

Thank you all!!!
https://pypi.org/project/cloud-composer-dag-test-utils/1.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman shollyman approved these changes

@busunkim96 busunkim96 busunkim96 approved these changes

@rachael-ds rachael-ds rachael-ds approved these changes

Assignees

@crwilcox crwilcox

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@leahecole @shollyman @busunkim96 @rachael-ds @engelke @crwilcox
0