8000 Add git dependency to Dataflow Flex template Dockerfile by nlecoy · Pull Request #5199 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Add git dependency to Dataflow Flex template Dockerfile #5199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 6, 2021
Merged

Add git dependency to Dataflow Flex template Dockerfile #5199

merged 2 commits into from
Jan 6, 2021

Conversation

nlecoy
Copy link
Contributor
@nlecoy nlecoy commented Jan 4, 2021

Description

Workaround to the issue opened here: https://issuetracker.google.com/issues/176570473

Note: It's a good idea to open an issue first for discussion.

Checklist

@nlecoy nlecoy requested a review from a team as a code owner January 4, 2021 14:08
@google-cla
Copy link
google-cla bot commented Jan 4, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 4, 2021
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 4, 2021
@kurtisvg
Copy link
Contributor
kurtisvg commented Jan 5, 2021

Hi @nlecoy - can you please make sure to sign the CLA?

@nlecoy
Copy link
Contributor Author
nlecoy commented Jan 6, 2021

Hi @kurtisvg - Already signed

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 6, 2021
@busunkim96
Copy link
Contributor

Looks like the cla bot needed a little kick. Thanks @nlecoy!

@busunkim96 busunkim96 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 6, 2021
@kurtisvg kurtisvg added the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 406bf46 into GoogleCloudPlatform:master Jan 6, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 6, 2021
@davidcavazos davidcavazos mentioned this pull request Jan 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nlecoy @kurtisvg @busunkim96 @googlebot @kokoro-team
0