8000 fix(samples): v1 and v1beta1 region tags collide by bcoe · Pull Request #4885 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

fix(samples): v1 and v1beta1 region tags collide #4885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 16, 2021
Merged

fix(samples): v1 and v1beta1 region tags collide #4885

merged 3 commits into from
Aug 16, 2021

Conversation

bcoe
Copy link
Contributor
@bcoe bcoe commented Oct 21, 2020 •
edited by kurtisvg
Loading

Description

The v1 healthcare region tags collide with the v1beta1 region tags.

Note: It's a good idea to open an issue first for discussion.

Checklist

@bcoe bcoe requested review from noerog and a team as code owners October 21, 2020 21:47
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 21, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 22, 2020
@busunkim96 busunkim96 removed their assignment Oct 23, 2020
@busunkim96 busunkim96 added the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 23, 2020
@blunderbuss-gcf blunderbuss-gcf bot removed the blunderbuss: assign Instruct blunderbuss to assign someone label Oct 23, 2020
@kurtisvg
Copy link
Contributor

I think at some point this was intended, and the plan was to remove the v1beta4 samples once v1 was complete.

@noerog PTAL

@kurtisvg kurtisvg assigned noerog and unassigned kurtisvg Oct 27, 2020
@noerog
Copy link
Contributor
noerog commented Nov 16, 2020

I deleted the majority of the v1beta1 code, but there are still some methods only available in v1beta1 that I want to keep, those being:

healthcare_conditional_update_resource
healthcare_conditional_patch_resource
healthcare_conditional_delete_resource

We could actually just delete all of the other region tags in v1beta1/fhir/ since none of them are being used except for the 3 above.

@snippet-bot
Copy link
snippet-bot bot commented Feb 26, 2021 •
edited
Loading
You are about to delete the following sample browser pages.

Here is the summary of changes.

You are about to delete 10 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

leahecole
leahecole reviewed Feb 26, 2021
View reviewed changes
Copy link
Collaborator
@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deleted the majority of the v1beta1 code, but there are still some methods only available in v1beta1 that I want to keep, those being:

healthcare_conditional_update_resource
healthcare_conditional_patch_resource
healthcare_conditional_delete_resource

We could actually just delete all of the other region tags in v1beta1/fhir/ since none of them are being used except for the 3 above.

Added suggested changes for removal @bcoe based on this comment from @noerog

@tmatsuo tmatsuo added the snippet-bot:force-run Force snippet-bot runs its logic label May 20, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label May 20, 2021
@tmatsuo tmatsuo added the snippet-bot:force-run Force snippet-bot runs its logic label Jun 1, 2021
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jun 1, 2021
@parthea parthea assigned bcoe and unassigned noerog Aug 14, 2021
@bcoe
Copy link
Contributor Author
bcoe commented Aug 16, 2021

@parthea I believe should be ready to land.

bcoe and others added 3 commits August 16, 2021 13:41
@bcoe @leahecole
fix(samples): v1 and v1beta1 region tags collide
a42e765
@bcoe @leahecole
Apply suggestions from code review
d887866 
Co-authored-by: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
@leahecole
fix lint
66ec4d0
@leahecole leahecole force-pushed the fix-region-tag-collisions branch from 56ee3db to 66ec4d0 Compare August 16, 2021 20:41
@leahecole leahecole added the automerge Merge the pull request once unit tests and other checks pass. label Aug 16, 2021
@leahecole leahecole merged commit d91506d into GoogleCloudPlatform:master Aug 16, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leahecole leahecole leahecole left review comments

@busunkim96 busunkim96 busunkim96 approved these changes

@noerog noerog noerog approved these changes

Assignees

@bcoe bcoe

@parthea parthea

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bcoe @kurtisvg @noerog @leahecole @busunkim96 @tmatsuo @parthea
0