8000 fix(run): add timestamp filter for faster test by tmatsuo · Pull Request #4630 · GoogleCloudPlatform/python-docs-samples · GitHub 8000
[go: up one dir, main page]
Skip to content

fix(run): add timestamp filter for faster test #4630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tmatsuo merged 1 commit into from
Sep 3, 2020
Merged

fix(run): add timestamp filter for faster test #4630

tmatsuo merged 1 commit into from
Sep 3, 2020

Conversation

@tmatsuo
Copy link
Contributor
@tmatsuo tmatsuo commented Sep 3, 2020

fixes #4609

Now the test finishes in a couple of minutes. The test used to take 30 minutes or so without this change.

@tmatsuo tmatsuo requested a review from dinagraves September 3, 2020 19:43
@tmatsuo tmatsuo requested review from a team, averikitsch and grant as code owners September 3, 2020 19:43
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2020
@tmatsuo tmatsuo merged commit 95b1028 into GoogleCloudPlatform:master Sep 3, 2020
@tmatsuo tmatsuo deleted the fix-run branch September 3, 2020 20:15
@busunkim96 busunkim96 mentioned this pull request Sep 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@averikitsch averikitsch Awaiting requested review from averikitsch

@grant grant Awaiting requested review from grant

2 more reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@dinagraves dinagraves dinagraves approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dinagraves dinagraves

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

testing(run): timeout in run/logging-manual

3 participants

@tmatsuo @busunkim96 @dinagraves
0