8000 Composer cloud build by leahecole · Pull Request #4607 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Composer cloud build #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 2, 2020
Merged

Composer cloud build #4607

merged 4 commits into from
Sep 2, 2020

Conversation

leahecole
Copy link
Collaborator
@leahecole leahecole commented Aug 31, 2020 •
edited
Loading

Description

This PR is the first part of something we talked about a few weeks go - automating the process of adding a pypi package to our test composer environment and keeping it up to date. To finish this, once this is merged, I will add a Cloud Build job that triggers on an update to the requirements-composer.txt file. The update that will happen to the Composer Environment does NOT disrupt any of our tests.

Some notes about this PR:

  • I have tested this renovate.json update in a test repo - it successfully monitors the requirements-composer.txt file
  • When this is merged, I'll need to create the cloud build trigger and give the service account permission to update the Composer Environment
  • There is a chance that installing this package will break our periodic/continuous builds, but that's probably a good thing because it means that the DAGs I have in our samples folder are outdated and need love

Fixes #4497

Note: It's a good idea to open an issue first for discussion.

Checklist

@leahecole leahecole requested a review from a team as a code owner August 31, 2020 19:37
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 31, 2020
@leahecole
Copy link
Collaborator Author

@bradmiro FYI this is also in anticipation of some of our intern code - they'll need these backport providers

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Sep 1, 2020
busunkim96
busunkim96 approved these changes Sep 1, 2020
View reviewed changes
@leahecole @busunkim96
Update composer/workflows/requirements-composer.txt
76ac9ce 
Co-authored-by: Bu Sun Kim <8822365+busunkim96@users.noreply.github.com>
@leahecole leahecole requested a review from bradmiro September 2, 2020 18:20
@leahecole leahecole merged commit 36c7b80 into master Sep 2, 2020
@leahecole leahecole deleted the composer-cloud-build branch September 2, 2020 18:38
@leahecole leahecole mentioned this pull request Sep 2, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busunkim96 busunkim96 busunkim96 approved these changes

@bradmiro bradmiro bradmiro approved these changes

Assignees

@busunkim96 busunkim96

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add python backport packages to composer environment (figure out if this can be dependabotted too)
3 participants
@leahecole @busunkim96 @bradmiro
0