8000 Nl by puneith · Pull Request #426 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Nl #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 38 commits into from
Jul 21, 2016
Merged

Nl #426

merged 38 commits into from
Jul 21, 2016

Conversation

puneith
Copy link
Contributor
@puneith puneith commented Jul 20, 2016

@jerjou @waprin please review.

Jerjou Cheng and others added 15 commits July 19, 2016 18:27
Add samples for natural language api.
5fb9def 
Change-Id: I089b244f1a0a2210fffab6f5747eed9f6150147a
@puneithk
fixed variable name error
aff93ad
@puneithk
logged error message with exception
03cb67b 
Change-Id: I8ff59d08f2ae8ce4cb3dd0b57b3548db3d5b8add
@puneithk
fixed variable unused error
e2cc3d5 
Change-Id: I1367429c3ceaefd0b0d36d9d7cad6ca29cbfdd2d
Refactor for clarity.
1789677 
Change-Id: Iecc1327db4aa21eb5ee61ce58bba3d142e600734
@puneithk
cast samples to int
1242524 
Change-Id: I33a6c3259dc5a9b0cc1ad081cd57acc452fc6b1a
@puneithk
added sample variable
3e4deb1 
Change-Id: Ic2b721f775601d2dfb718be26d425e7c2e91eb8a
@puneithk
fixed indentation bug
4ffc546 
Change-Id: I2eac2d41e3f8d96c1d049dbbc7b48c96d5fded0a
Fix lint errors
7ca9918 
Change-Id: I026963be93ca3ef776420807e14abdcfcc5fe95f
Remove movie_nl sample until it's more stable.
0be30eb 
Change-Id: Iab58378f40c760e88f2b3cc0806985894ce77e76
Revert "Remove movie_nl sample until it's more stable."
47c7c63 
This reverts commit 0be30eb.
@puneithk
catch HttpError and log it
0a8d040 
Change-Id: Ib2f1a2b04c0d00cd62d178d92430379b64ea9781
@puneithk
added retry in the request
8076a63 
Change-Id: Iea8672b60bd6ebe9602378bb8b2622a44b48e608
@puneithk
Merge branch 'nl' of github.com:GoogleCloudPlatform/python-docs-sampl…
f39bd6e 
…es into nl
@puneithk
resolved README conflicts
c9ac6d3
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2016
@theacodes theacodes added In Progress and removed cla: yes This human has signed the Contributor License Agreement. labels Jul 20, 2016
waprin
waprin reviewed Jul 20, 2016
View reviewed changes
language/movie_nl/main.py
items.sort(reverse=True)
8000 items = [json.dumps(item[1]) for item in items]

if reverse_bool:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry if I'm misunderstanding this, but it looks like you are reversing then condtionally reverse again. any way to write to just conditionally reverse once?

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 20, 2016
jerjou
jerjou reviewed Jul 20, 2016
View reviewed changes
language/movie_nl/main.py

try:
sentiments = [get_sentiment(service, sentence) for sentence in sentences]
except HttpError as e:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This try/catch is unnecessary.

@waprin
Copy link
Contributor
waprin commented Jul 21, 2016

LGTM

@waprin
Copy link
Contributor
waprin commented Jul 21, 2016

Given Traivs passes I'm sure it's fine but is this a nox issue?

import file mismatch:
imported module 'main_test' has this __file__ attribute:
  /Users/waprin/code/python-docs-samples/language/movie_nl/main_test.py
which is not the same as the test file we want to collect:
  /Users/waprin/code/python-docs-samples/language/ocr_nl/main_test.py

@waprin
Copy link
Contributor
waprin commented Jul 21, 2016

That's when I just run

nox --session tests -- language/

@puneith
Copy link
Contributor Author
puneith commented Jul 21, 2016

So when I do nox it is successful. I see t 8000 here is movie_nl and ocr_nl in your output above? Is this something with ocr? Donno?

@waprin
Copy link
Contributor
waprin commented Jul 21, 2016

Are you doing just nox or the command I ran that just does the language directory? It passes on Travis so likely an issue on my laptop ,just mentioning here....

@puneith
Copy link
Contributor Author
puneith commented Jul 21, 2016

@waprin I had to update the README and also get rid of the FileType for the rank feature.

@waprin
Copy link
Contributor
waprin commented Jul 21, 2016

alright i just ran commands again and worked for me. meeeerge away

@waprin
Copy link
Contributor
waprin commented Jul 21, 2016

I still have that test issue but again pretty sure it's nox related. out of curiosity can you try that? nox --session tests -- language

@theacodes
Copy link
Contributor

You need to specify the individual sample -- language/movie_nl

On Thu, Jul 21, 2016, 3:09 PM Bill Prin notifications@github.com wrote:

I still have that test issue but again pretty sure it's nox related. out
of curiosity can you try that? nox --session tests -- language

—
You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub
#426 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAPUcxToC4BolGGqTVBEU94FUiM8FctDks5qX-4TgaJpZM4JRN78
.

@puneith puneith merged commit df0153e into master Jul 21, 2016
@jerjou
Copy link
Contributor
jerjou commented Jul 21, 2016

Next time you merge, can you please squash your commits?

@theacodes
Copy link
Contributor

Please let Jerjou, Bill, or Myself merge in the future, just for consistency. I'm going to manually squash these commits.

@theacodes theacodes deleted the nl branch July 21, 2016 23:01
@theacodes theacodes restored the nl branch July 21, 2016 23:10
@theacodes theacodes deleted the nl branch July 21, 2016 23:17
msampathkumar pushed a commit that referenced this pull request Nov 14, 2022
@renovate-bot
chore(deps): update dependency pytest to v7.1.3 (#426)
11d4f37
@msampathkumar msampathkumar mentioned this pull request Nov 14, 2022
Merged
8 tasks
holtskinner added a commit that referenced this pull request Jan 3, 2023
@holtskinner @renovate-bot
chore(deps): update dependency google-cloud-storage to v2.7.0 (#426)
822488b 
* chore(deps):
6D40
 update dependency google-cloud-storage to v2.7.0

* docs(samples): removed batch_process_documents_sample_bad_input_test

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@holtskinner holtskinner mentioned this pull request Jan 4, 2023
Merged
8 tasks
holtskinner added a commit that referenced this pull request Jan 4, 2023
@holtskinner @renovate-bot
chore(deps): update dependency google-cloud-storage to v2.7.0 (#426)
3e9f022 
* chore(deps): update dependency google-cloud-storage to v2.7.0

* docs(samples): removed batch_process_documents_sample_bad_input_test

Co-authored-by: Renovate Bot <bot@renovateapp.com>
dandhlee pushed a commit that referenced this pull request Jan 5, 2023
@holtskinner @renovate-bot @dandhlee
chore(deps): update dependency google-cloud-storage to v2.7.0 (#426)
31d6a22 
* chore(deps): update dependency google-cloud-storage to v2.7.0

* docs(samples): removed batch_process_documents_sample_bad_input_test

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@Sita04 Sita04 mentioned this pull request Feb 7, 2023
Merged
8 tasks
Sita04 pushed a commit that referenced this pull request Feb 7, 2023
@renovate-bot
chore(deps): update all dependencies (#426)
459ba2c
dizcology pushed a commit that referenced this pull request Jun 16, 2023
9E88
@renovate-bot
chore(deps): update dependency google-cloud-bigquery to v3.4.2 (#426)
7eff80c
@dizcology dizcology mentioned this pull request Jun 16, 2023
Merged
9 tasks
dizcology pushed a commit that referenced this pull request Jul 10, 2023
@renovate-bot @dizcology
chore(deps): update dependency google-cloud-bigquery to v3.4.2 (#426)
9361eb7
leahecole pushed a commit that referenced this pull request Jul 11, 2023
@renovate-bot @leahecole
chore(deps): update dependency google-cloud-bigquery to v3.4.2 (#426)
af20d70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@puneith @jerjou @waprin @theacodes @googlebot @puneithk
0