Nl #426
Nl #426
Conversation
Change-Id: I089b244f1a0a2210fffab6f5747eed9f6150147a
Change-Id: I8ff59d08f2ae8ce4cb3dd0b57b3548db3d5b8add
Change-Id: I1367429c3ceaefd0b0d36d9d7cad6ca29cbfdd2d
Change-Id: Iecc1327db4aa21eb5ee61ce58bba3d142e600734
Change-Id: I33a6c3259dc5a9b0cc1ad081cd57acc452fc6b1a
Change-Id: Ic2b721f775601d2dfb718be26d425e7c2e91eb8a
Change-Id: I2eac2d41e3f8d96c1d049dbbc7b48c96d5fded0a
Change-Id: I026963be93ca3ef776420807e14abdcfcc5fe95f
Change-Id: Iab58378f40c760e88f2b3cc0806985894ce77e76
This reverts commit 0be30eb.
Change-Id: Ib2f1a2b04c0d00cd62d178d92430379b64ea9781
Change-Id: Iea8672b60bd6ebe9602378bb8b2622a44b48e608
| items.sort(reverse=True) | ||
| items = [json.dumps(item[1]) for item in items] | ||
|
|
||
| if reverse_bool: |
There was a problem hiding this comment.
sorry if I'm misunderstanding this, but it looks like you are reversing then condtionally reverse again. any way to write to just conditionally reverse once?
|
|
||
| try: | ||
| sentiments = [get_sentiment(service, sentence) for sentence in sentences] | ||
| except HttpError as e: |
There was a problem hiding this comment.
This try/catch is unnecessary.
|
LGTM |
|
Given Traivs passes I'm sure it's fine but is this a nox issue? |
|
That's when I just run
|
|
So when I do nox it 8000 is successful. I see there is movie_nl and ocr_nl in your output above? Is this something with ocr? Donno? |
|
Are you doing just nox or the command I ran that just does the language directory? It passes on Travis so likely an issue on my laptop ,just mentioning here.... |
|
@waprin I had to update the README and also get rid of the FileType for the rank feature. |
|
alright i just ran commands again and worked for me. meeeerge away |
|
I still have that test issue but again pretty sure it's nox related. out of curiosity can you try that? |
|
You need to specify the individual sample -- language/movie_nl On Thu, Jul 21, 2016, 3:09 PM Bill Prin notifications@github.com wrote:
|
|
Next time you merge, can you please squash your commits? |
|
Please let Jerjou, Bill, or Myself merge in the future, just for consistency. I'm going to manually squash these commits. |
* chore(deps): update dependency google-cloud-storage to v2.7.0 * docs(samples): removed batch_process_documents_sample_bad_input_test Co-authored-by: Renovate Bot <bot@renovateapp.com>
* chore(deps): update dependency google-cloud-storage to v2.7.0 * docs(samples): removed batch_process_documents_sample_bad_input_test Co-authored-by: Renovate Bot <bot@renovateapp.com>
* chore(deps): update dependency google-cloud-storage to v2.7.0 * docs(samples): removed batch_process_documents_sample_bad_input_test Co-authored-by: Renovate Bot <bot@renovateapp.com>
@jerjou @waprin please review.