8000 testing: update the python versions in the Dockerfile by tmatsuo · Pull Request #4123 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

testing: update the python versions in the Dockerfile #4123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 19, 2020
Merged

testing: update the python versions in the Dockerfile #4123

merged 3 commits into from
Jun 19, 2020

Conversation

tmatsuo
Copy link
Contributor
@tmatsuo tmatsuo commented Jun 18, 2020 •
edited
Loading

also enable the Docker image upload in python 3.8 periodic build.

fixes #4126

@tmatsuo tmatsuo requested review from kurtisvg and skuruppu June 18, 2020 21:55
@tmatsuo tmatsuo requested a review from a team as a code owner June 18, 2020 21:55
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 18, 2020
@tmatsuo
Copy link
Contributor Author
tmatsuo commented Jun 18, 2020

Doh. I overlooked there is python 2.7.18

Takashi Matsuo added 2 commits June 18, 2020 23:35
testing: update the python versions in the Dockerfile
b60a154 
also enable the Docker image upload in python 3.8 periodic build.
use Python 2.7.18
084d7b8
@tmatsuo
Copy link
Contributor Author
tmatsuo commented Jun 19, 2020 •
edited
Loading

The current logic for installing Python seems flaky. I think it fails to import gpg keys.
Also gpg --verify ... returns 0 even if there's no public key.

The tests in py-3.7 builds are all skipped because there's no python-3.7
Some tests in py-2.7 builds failed because there's non python.h for python2.7.

I'll modify the python installation to fail when key verification fails.

Update:

Actually gpg --verify returns non-zero exit code, but because gpg --verify is in for loop, it doesn't immediately exit with non-zero status. Instead, the for loop exits with non-zero status code. Because we set set -ex in the for loop, the outer for loop doesn't exit because it is not affected by set -e.

I changed the order of the script and now it should fail upon signature verification failures.

@tmatsuo
Copy link
Contributor Author
tmatsuo commented Jun 19, 2020

py-2.7 build failed with several errors with "bad zip files". I'll restart it.

@skuruppu skuruppu requested a review from larkee June 19, 2020 09:42
@tmatsuo
Copy link
Contributor Author

The builds are all green, merging

@tmatsuo tmatsuo merged commit d51deb4 into GoogleCloudPlatform:master Jun 19, 2020
@tmatsuo tmatsuo deleted the python-versions branch June 19, 2020 15:20
This was referenced Jun 19, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skuruppu skuruppu Awaiting requested review from skuruppu

@larkee larkee Awaiting requested review from larkee

1 more reviewer

@kurtisvg kurtisvg kurtisvg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@kurtisvg kurtisvg

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[flake] Build failures due to python build failure

3 participants

@tmatsuo @kurtisvg @googlebot
0