8000 automl: remove vision samples no longer on cgc by Strykrol · Pull Request #3693 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

automl: remove vision samples no longer on cgc #3693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 7, 2020
Merged

automl: remove vision samples no longer on cgc #3693

merged 10 commits into from
May 7, 2020

Conversation

Strykrol
Copy link
Contributor
@Strykrol Strykrol commented May 5, 2020

These samples aren't published anywhere for public consumption, and were recently removed from their most recent home (vision/alpha files).

These can safely be removed as part of clean-up to reduce the clutter of unused code in sample repositories. Please feel free to reach out internally for more information on this initiative.

@Strykrol Strykrol requested review from nnegrey, sirtorry, telpirion and a team as code owners May 5, 2020 23:07
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 5, 2020
@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 6, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 6, 2020
@tmatsuo
Copy link
Contributor
tmatsuo commented May 6, 2020

@Strykrol

In case you don't have access to the logs, here is an error:

./model_test.py:23:1: F401 'automl_vision_model' imported but unused
import automl_vision_model
^

@Strykrol
Copy link
Contributor Author
Strykrol commented May 6, 2020

Thank you @tmatsuo. Is it at all notable that the test file (now) only tests a create method that isn't even part of this PR's affected files?

That is, should the test be refactored to specifically test the automl_vision_model create method.

@tmatsuo tmatsuo added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 7, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 7, 2020
@tmatsuo
Copy link
Contributor
tmatsuo commented May 7, 2020

@Strykrol
I'm going to merge this, but currently test_model_create_status_delete is skipped. Can you file an issue to enable it again?

@tmatsuo tmatsuo merged commit f6fb9e1 into GoogleCloudPlatform:master May 7, 2020
@Strykrol Strykrol mentioned this pull request May 7, 2020
Closed
@Strykrol
Copy link
Contributor Author
Strykrol commented May 7, 2020

Done. #3706

@Strykrol Strykrol deleted the 7FB2 automl_alpha_snippets branch May 7, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo approved these changes

@nnegrey nnegrey Awaiting requested review from nnegrey

@sirtorry sirtorry Awaiting requested review from sirtorry

@telpirion telpirion Awaiting requested review from telpirion

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Strykrol @tmatsuo @googlebot @kokoro-team
0