-
Notifications
You must be signed in to change notification settings - Fork 6.5k
remove misleading raise_for_status #2948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gcf-merge-on-green
merged 12 commits into
GoogleCloudPlatform:master
from
TAOXUY:raise_for_status
May 5, 2020
Merged
remove misleading raise_for_status #2948
gcf-merge-on-green
merged 12 commits into
GoogleCloudPlatform:master
from
TAOXUY:raise_for_status
May 5, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busunkim96
reviewed
Feb 20, 2020
f0ad660
to
acc6c0a
Compare
busunkim96
reviewed
Feb 20, 2020
acc6c0a
to
3cf40a0
Compare
Please take a look |
/retest |
@daniel-sanche can you take another look at this please? |
daniel-sanche
approved these changes
Apr 22, 2020
@busunkim96, please take a look. |
busunkim96
reviewed
May 1, 2020
@busunkim96, please take a look. |
busunkim96
approved these changes
May 5, 2020
Thank you for the contribution @TAOXUY! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the response has error, the error detail is not exposed because of raise_for_status, so remove it and show the detailed message.
For instance, the detailed error is UNAUTHENTICATED:Method doesn't allow unregistered callers (callers without established identity). Please use API Key or other form of API consumer identity to call this API.
but we only got requests.exceptions.HTTPError: 401 Client Error: Unauthorized for url.