10000 Add GAE billing tests + fix region tags by ace-n · Pull Request #2774 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Add GAE billing tests + fix region tags 10000 #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Feb 5, 2020
Merged

Add GAE billing tests + fix region tags #2774

merged 18 commits into from
Feb 5, 2020

Conversation

ace-n
Copy link
@ace-n ace-n commented Feb 5, 2020

Fixes #2772

@ace-n ace-n requested a review from grant February 5, 2020 01:14
@ace-n ace-n requested a review from a team as a code owner February 5, 2020 01:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 5, 2020
@ace-n
Copy link
Author
ace-n commented Feb 5, 2020

Chatted offline with @kurtisvg - since GCF only supports Python 3.7, we can disable functions/* tests for the other versions (2.7, 3.5, 3.6)

@ace-n ace-n merged commit 96a08de into master Feb 5, 2020
@ace-n ace-n deleted the gae-billing-tests-2772 branch February 5, 2020 23:17
tmatsuo
tmatsuo reviewed May 18, 2020
View reviewed changes
.kokoro/tests/run_tests.sh
# Skip unsupported Python versions for Cloud Functions
# (Some GCF samples' dependencies don't support them)
if [[ "$file" == "functions/"* ]]; then
PYTHON_VERSION="$(python --version 2>&1)"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, this code is completely wrong.

This code checks the default Python version, rather than Python version in the nox session.

This resulted in disabling all the tests under functions directory. #3767 removed this code block then our tests started to fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmatsuo tmatsuo tmatsuo left review comments

@andrewsg andrewsg andrewsg approved these changes

@grant grant grant approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests to GAE billing GCF sample
6 participants
@ace-n @tmatsuo @andrewsg @grant @kurtisvg @googlebot
0