Fix encoding of object names. #2473
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per the docs, the "/" character should not be escaped in the object name portion of the signed URL. Also, Python 2 and 3 differ on whether the tilde character should be escaped by the url library's `quote` method, so in order for our sample to work on both Python2 and Python3, we should always specify the tilde as a "safe" character. For reference, we already fixed this same bug in gsutil a few months ago: https://github.com/GoogleCloudPlatform/gsutil/blob/4531874e3a3d45ca642fc9c9fa438ba58c8f1494/gslib/commands/signurl.py#L543
|
Context: I saw this script included in our docs at https://cloud.google.com/storage/docs/access-control/signing-urls-manually, and was trying to use it to reproduce the issue mentioned in https://issuetracker.google.com/issues/142546499, when I noticed that forward slashes in object names were being encoded. It's mentioned in both our docs and the AWS S3 docs here that you should not escape forward slashes in the object name. |
|
Summoning @frankyn for review |
frankyn
approved these changes
Oct 11, 2019
|
@houglum can you ping TW to republish documentation? |
|
Done! CC'd you on the email. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the docs, the "/" character should not be escaped in the object name
portion of the signed URL. Also, Python 2 and 3 differ on whether the
tilde character should be escaped by the url library's
quotemethod,so in order for our sample to work on both Python2 and Python3, we
should always specify the tilde as a "safe" character. For reference, we
already fixed this same bug in gsutil a few months ago:
https://github.com/GoogleCloudPlatform/gsutil/blob/4531874e3a3d45ca642fc9c9fa438ba58c8f1494/gslib/commands/signurl.py#L543