[IAM] Add client initialization to each access.py sample #2297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tswast
approved these changes
Jul 24, 2019
|
Thanks! I agree this will be clearer for users who find these snippets in non-ResourceManager contexts. |
gguuss
pushed a commit
that referenced
this pull request
Jul 24, 2019
* Initialize client in each IAM access sample * lint * lint
8000
|
Looks like there's maybe a problem with requirements.txt? https://travis-ci.org/GoogleCloudPlatform/python-docs-samples/builds/563281779?utm_medium=notification&utm_source=email is complaining about missing |
|
FYI: in the future, only a subset of the tests run on travis when a PR is from a fork. Best to create a new branch on python-docs-samples, instead. (I usually prefix the branch name with either an issue number or my username) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializes a
cloudresourcemanagerclient in each snippet.Reason: received a bug report where a user tried to call these functions on an IAM API client, not a ResourceManager client. This sample code lives in the IAM docs, so not being clear about which API is used here could be confusing.