8000 codelabs/functions: create 'Python Powered' codelab by di · Pull Request #2262 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

codelabs/functions: create 'Python Powered' codelab #2262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 11, 2019
Merged

codelabs/functions: create 'Python Powered' codelab #2262

merged 3 commits into from
Jul 11, 2019

Conversation

di
Copy link
Member
@di di commented Jul 10, 2019

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 10, 2019
@di di force-pushed the functions-codelab branch from f70e89b to 98b09c9 Compare July 10, 2019 10:25
theacodes
theacodes suggested changes Jul 10, 2019
View reviewed changes
Copy link
Contributor
@theacodes theacodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits but otherwise looks good.

codelabs/functions/python_powered/test_main.py Outdated
from main import hello_name, hello_world


class TestHello(TestCase):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I think you're using this in your codelab as example code, yeah?

If so, this is fine, otherwise, we generally use pytest style.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. I think you're using this in your codelab as example code, yeah?

Yeah. I would have used pytest style, but the conftest.py in this repo seems incompatible with Python 3?

$ python -m pytest
ImportError while loading conftest '.../googlecloudplatform/python-docs-samples/conftest.py'.
../../../conftest.py:17: in <module>
    import mock
E   ModuleNotFoundError: No module named 'mock'

(It also saves a step for the codelab user here.)

@theacodes theacodes merged commit 55bb04f into GoogleCloudPlatform:master Jul 11, 2019
@di di deleted the functions-codelab branch July 12, 2019 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@di @theacodes @googlebot
0