8000 Set redis version to ">=3.1.0" by darrencarlton · Pull Request #2244 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Set redis version to ">=3.1.0" #2244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2019
Merged

Set redis version to ">=3.1.0" #2244

merged 2 commits into from
Jul 22, 2019

Conversation

darrencarlton
Copy link
Contributor

The current version of the Redis Python library is 3.2.1. Instead of hard-coding "3.2.1" and having to update the code example again, I suggest we set this to "greater than or equal to 3.1.0".

I tested the code example with this setting, and it worked just fine.

@darrencarlton
Set redis version to ">=3.1.0"
11b555e 
The current version of the Redis Python library is 3.2.1. Instead of hard-coding "3.2.1" and having to update the code example again, I suggest we set this to "greater than or equal to 3.1.0".

I tested the code example with this setting, and it worked just fine.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2019
gguuss
gguuss suggested changes Jul 17, 2019
View reviewed changes
Copy link
Contributor
@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tend to prefer == over >= and ~= to avoid breaking the sample code in the event that a dependency has breaking changes. Can you instead use == and the latest version?

gguuss
gguuss approved these changes Jul 22, 2019
View reviewed changes
Copy link
Contributor
@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gguuss gguuss merged commit ef4e137 into GoogleCloudPlatform:master Jul 22, 2019
@darrencarlton
Copy link
Contributor Author

Thanks, Gus

@darrencarlton darrencarlton deleted the dcarlton-redis-lib-version branch July 22, 2019 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@gguuss gguuss gguuss approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darrencarlton @gguuss @googlebot
0