8000 Functions: improve existing sample by anguillanneuf · Pull Request #2220 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Functions: improve existing sample #2220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 19, 2019
Merged

Functions: improve existing sample #2220

merged 4 commits into from
Jul 19, 2019

Conversation

anguillanneuf
Copy link
Member
@anguillanneuf anguillanneuf commented Jun 13, 2019 •
edited
Loading

This addresses user feedback that compares our current Hello World example for Cloud Function with Cloud Pub/Sub with that of Firebase with Cloud Pub/Sub.

1. else clause actually outputs something else.
2. Show how users can access message attributes, publish time, and message IDs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 13, 2019
@anguillanneuf anguillanneuf requested review from ace-n and andrewsg June 13, 2019 23:05
@anguillanneuf anguillanneuf requested a review from tswast June 14, 2019 19:24
andrewsg
andrewsg requested changes Jun 17, 2019
View reviewed changes
@ace-n ace-n removed their request for review June 20, 2019 00:10
@anguillanneuf anguillanneuf requested a review from andrewsg July 17, 2019 18:56
@anguillanneuf
Copy link
Member Author
anguillanneuf commented Jul 17, 2019 •
edited
Loading

I have decided to just update the sample to show how to access message ID and publish time.

"Hello world!" just indicates something is failing. If users see "Hello {something else}!", they can be sure that everything has worked.

@andrewsg
Copy link
Member

Thanks!

@anguillanneuf anguillanneuf merged commit 729efa6 into master Jul 19, 2019
@anguillanneuf anguillanneuf deleted the gcf_cps branch July 19, 2019 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ace-n ace-n ace-n left review comments

@tswast tswast tswast approved these changes

@andrewsg andrewsg andrewsg approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anguillanneuf @andrewsg @tswast @ace-n @googlebot
0