8000 storage: Update signed url sample by frankyn · Pull Request #2020 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

storage: Update signed url sample #2020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

storage: Update signed url sample #2020

merged 1 commit into from
Feb 21, 2019

Conversation

frankyn
Copy link
Contributor
@frankyn frankyn commented Feb 21, 2019

Short PR to modify a value used to be consistent with gsutil.

gcs -> storage

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 21, 2019
@frankyn frankyn requested a review from engelke February 21, 2019 20:44
engelke
engelke approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor
@engelke engelke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankyn
Copy link
Contributor Author
frankyn commented Feb 21, 2019

Thank you @engelke

@frankyn frankyn merged commit 0496a35 into master Feb 21, 2019
@frankyn frankyn deleted the update-generate-signed-url branch February 21, 2019 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelke engelke engelke approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankyn @engelke @googlebot
0