8000 Possible fix to message encoding issue by CarlosMendonca · Pull Request #1990 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Possible fix to message encoding issue #1990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2019
Merged

Possible fix to message encoding issue #1990

merged 1 commit into from
Feb 1, 2019

Conversation

CarlosMendonca
Copy link
Contributor

It throws an exception when trying to parse to JSON. Could use a second opinion on this solution. Original Codelab instructions available here.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 1, 2019
gguuss
gguuss approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor
@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gguuss gguuss merged commit 1cad11a into GoogleCloudPlatform:master Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gguuss gguuss gguuss approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CarlosMendonca @gguuss @googlebot
0