storage: bucket policy only samples #1976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engelke
reviewed
Jan 24, 2019
| @@ -1,2 +1,3 @@ | |||
| google-cloud-pubsub==0.38.0 | |||
| google-cloud-storage==1.13.2 | |||
| #google-cloud-storage==1.13.2 | |||
| ../google-cloud-python/storage | |||
There was a problem hiding this comment.
Need to have a valid requirements.txt and then pass Kokoro presubmit tests.
There was a problem hiding this comment.
Sg, should the review wait til then?
Clarifying context: The client is not yet released. I ran tests locally and they passed.
There was a problem hiding this comment.
Yes, I think samples here should only use released libraries so anybody could work from them. So this can just wait for that. Is that okay?
engelke
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Samples for the GCS Bucket Policy Only feature. The client library is not yet released to the Python package manager and requires a requirements.txt update before merge.