8000 Use HTTPS instead of HTTP for Google Analytics in Python samples by thomasgassmann · Pull Request #1699 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Use HTTPS instead of HTTP for Google Analytics in Python samples #1699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gguuss merged 2 commits into from
Nov 15, 2018
Merged

Use HTTPS instead of HTTP for Google Analytics in Python samples #1699

gguuss merged 2 commits into from
Nov 15, 2018

Conversation

@thomasgassmann
Copy link
Contributor
@thomasgassmann thomasgassmann commented Sep 11, 2018

No description provided.

@googlebot
Copy link
googlebot commented Sep 11, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Sep 11, 2018
@thomasgassmann
Copy link
Contributor Author
thomasgassmann commented Sep 11, 2018

I signed it!

@googlebot
Copy link
googlebot commented Sep 11, 2018

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Sep 11, 2018
gguuss
gguuss approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor
@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as seen in the docs "All data should be sent securely with the HTTPS protocol."

thanks for your fix!

@gguuss
Copy link
Contributor
gguuss commented Nov 15, 2018

@thomasgassmann update your branch and I'll merge.

@thomasgassmann thomasgassmann force-pushed the use-https-google-analytics branch from 13a4132 to 3c4bcec Compare November 15, 2018 20:12
@thomasgassmann
Copy link
Contributor Author
thomasgassmann commented Nov 15, 2018

@gguuss Updated the branch.

@gguuss gguuss merged commit 5f1a321 into GoogleCloudPlatform:master Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gguuss gguuss gguuss approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thomasgassmann @googlebot @gguuss
0