fix(template): update template to not test 3.13 #13238
Conversation
There was a problem hiding this comment.
Hello @glasnt, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses CI issues by updating the generative_ai/template_folder/noxfile_config.py file to exclude Python 3.13 from the test matrix. This is because the template currently fails due to a dependency on pandas, which doesn't yet support Python 3.13. The change aligns the template with other samples in the folder that don't test for Python 3.13.
Highlights
- Bug fix: Addresses CI failures related to Python 3.13 incompatibility with
pandasin thegenerative_ai/template folder. - Configuration update: Updates
noxfile_config.pyto exclude Python 3.13 from the test matrix for the template. - Consistency: Ensures the template's testing configuration is consistent with other samples in the folder.
Changelog
- generative_ai/template_folder/noxfile_config.py
- Added '3.13' to the
ignored_versionslist inTEST_CONFIG_OVERRIDEat line 25, effectively skipping tests for Python 3.13.
- Added '3.13' to the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A template's plight, a version's sting,
Python 3.13, a different thing.
Pandas unmet, a CI's frown,
Excluded now, till support is found.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request updates the noxfile_config.py file to exclude Python 3.13 from the test matrix for the generative_ai/template_folder template. This is done to address CI failures caused by incompatibility issues with the pandas library. The change appears straightforward and addresses the reported issues.
Merge Readiness
The pull request appears to be ready for merging. The change is simple and directly addresses the reported CI issues. I am unable to directly approve the pull request, and recommend that others review and approve this code before merging.
Description
Resolves CI issues with #12851, #12861, #12865, #12947, #12952, #12959, #12975, #13152
The
generative_ai/template folder contains valid tests, and is currently failing the above PRs due to requiringpandas, which as of pandas 2.2.3 does not support Python 3.13.All other samples within the folder don't test for Python 3.13, so update the template to match.
cc @msampathkumar