10000 [endpoints] Update protoc commands to match documentation. by kryzthov · Pull Request #1188 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

[endpoints] Update protoc commands to match documentation. #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2017
Merged

[endpoints] Update protoc commands to match documentation. #1188

merged 1 commit into from
Nov 2, 2017

Conversation

kryzthov
Copy link
Contributor
@kryzthov kryzthov commented Nov 1, 2017

@navinger

  • Use long flags for better readability.
  • Change API descriptor file from out.pb to api_descriptor.pb.
  • Use same protoc command everywhere for consistency and simplicity.

@kryzthov
Update protoc commands to match documentation.
5d1aedd 
 - Use long flags for better readability.
 - Change API descriptor file from `out.pb` to `api_descriptor.pb`.
 - Use same protoc command everywhere for consistency and simplicity.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 1, 2017
@navinger
Copy link
Contributor
navinger commented Nov 2, 2017

LGTM.

@theacodes theacodes merged commit c010b7f into GoogleCloudPlatform:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kryzthov @navinger @theacodes @googlebot
0