10000 [issue-1788] added firedbase tests by irudykss · Pull Request #11533 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

[issue-1788] added firedbase tests #11533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 20, 2024
Merged

[issue-1788] added firedbase tests #11533

merged 1 commit into from
Jun 20, 2024

Conversation

irudykss
Copy link
Contributor

Description

Fixes #1788

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@google-cla Google CLA
Copy link
google-cla bot commented Apr 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: firestore Issues related to the Firestore API. labels Apr 17, 2024
@irudykss irudykss requested a review from m-strzelczyk April 18, 2024 07:11
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 18, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 18, 2024
@m-strzelczyk
Copy link
Contributor

I need to find someone with access to the python-docs-samples-firestore project. To get this sorted I guess.

@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 17, 2024
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2024
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 27, 2024
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2024
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 28, 2024
@m-strzelczyk
Copy link
Contributor

I think I fixed whatever problems we had with the python-docs-samples-firestore, but now the tests seem to take forever. I guess we will soon just get a timeout error. Can you investigate?

@m-strzelczyk
Copy link
Contributor

In the test project, I see that we did hit quota.

5gHiLCttLq4PHJo

I guess there's some problem with the tests if we use up all 50k operations.

@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 17, 2024
@BigBlackWolf BigBlackWolf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 18, 2024
@BigBlackWolf BigBlackWolf marked this pull request as ready for review June 18, 2024 15:54
@BigBlackWolf BigBlackWolf requested review from a team as code owners June 18, 2024 15:54
@BigBlackWolf
Copy link
Contributor

Seems db contained a lot of records, because I tried to ran the tests in my environment and there was only ~700 read/write operations. After cleaning up project DB (#11863) the CI passed.

@m-strzelczyk m-strzelczyk merged commit 963a3ee into main Jun 20, 2024
14 checks passed
@m-strzelczyk m-strzelczyk deleted the issue-1788 branch June 20, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk m-strzelczyk approved these changes

Assignees

@m-strzelczyk m-strzelczyk

Labels
api: firestore Issues related to the Firestore API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FIrestore Samples] Update tests to be self-contained and verified for correctness.
5 participants
@irudykss @m-strzelczyk @BigBlackWolf @danieljbruce @kokoro-team
0