Add support for overwrite attributes #1142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theacodes
reviewed
Sep 27, 2017
| @@ -64,6 +64,8 @@ def summarize(message): | |||
| bucket_id = attributes['bucketId'] | |||
| object_id = attributes['objectId'] | |||
| generation = attributes['objectGeneration'] | |||
| overwroteGeneration = attributes['overwroteGeneration'] | |||
There was a problem hiding this comment.
our style guide is snake_case for variable names, even if you're plucking them from the API repr.
There was a problem hiding this comment.
Oh dangit, I do that every time. I just can't stop Javaing.
theacodes
approved these changes
Sep 27, 2017
|
@BrandonY arg, this seems to fail with the system tests https://travis-ci.org/GoogleCloudPlatform/python-docs-samples/builds/280571893 Can you see about fixing it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for displaying GCS overwrite-related attributes.
Also fixes a formatting bug for output.