8000 module -> service in app.yamls by theacodes · Pull Request #1020 · GoogleCloudPlatform/python-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

module -> service in app.yamls #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2017
Merged

module -> service in app.yamls #1020

merged 1 commit into from
Jul 14, 2017

Conversation

theacodes
Copy link
Contributor
@theacodes theacodes commented Jul 14, 2017 •
edited by dpebot
Loading

Resolves #1016

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 14, 2017
@theacodes theacodes requested a review from andrewsg July 14, 2017 18:22
@theacodes
Copy link
Contributor Author

@dpebot will you merge when travis passes?

@dpebot
Copy link
Collaborator
dpebot commented Jul 14, 2017

Okay! I'll merge when all statuses are green and all reviewers approve.

@dpebot dpebot added the automerge Merge the pull request once unit tests and other checks pass. label Jul 14, 2017
@dpebot dpebot self-assigned this Jul 14, 2017
@theacodes theacodes merged commit f18e7c6 into master Jul 14, 2017
@theacodes theacodes deleted the module-to-service branch July 14, 2017 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewsg andrewsg andrewsg approved these changes

Assignees

@dpebot dpebot

Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@theacodes @dpebot @andrewsg @googlebot
0