8000 feat(dataplex): add code samples for Entry Type by jacspa96 · Pull Request #9574 · GoogleCloudPlatform/java-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

feat(dataplex): add code samples for Entry Type #9574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact it 8000 s maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 15, 2024
Merged

feat(dataplex): add code samples for Entry Type #9574

merged 6 commits into from
Oct 15, 2024

Conversation

jacspa96
Copy link
Contributor

Description

Fixes b/368503059

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: dataplex Issues related to the Dataplex API. labels Oct 14, 2024
@jacspa96 jacspa96 marked this pull request as ready for review October 14, 2024 08:30
@jacspa96 jacspa96 requested review from yoshi-approver and a team as code owners October 14, 2024 08:30
@snippet-bot Snippet Bot
Copy link
snippet-bot bot commented Oct 14, 2024

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
8000

@jacspa96 jacspa96 requested a review from cerberus97 October 14, 2024 08:31
@jacspa96 jacspa96 changed the title Entry type snippets feat(dataplex): add code samples for Entry Type Oct 14, 2024
@jacspa96 jacspa96 requested a review from avijain25 October 14, 2024 08:33
@jacspa96 jacspa96 assigned cerberus97 and unassigned duzun Oct 14, 2024
iennae
iennae approved these changes Oct 15, 2024
View reviewed changes
Copy link
Contributor
@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@iennae iennae merged commit 34c0352 into GoogleCloudPlatform:main Oct 15, 2024
8 checks passed
@jacspa96 jacspa96 deleted the entry-type-snippets branch October 15, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iennae iennae iennae approved these changes

@avijain25 avijain25 avijain25 approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

@cerberus97 cerberus97 Awaiting requested review from cerberus97

Assignees

@cerberus97 cerberus97

Labels
api: dataplex Issues related to the Dataplex API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jacspa96 @iennae @avijain25 @duzun @cerberus97 @gabrysiaolsz
0