8000 docs: fix Bigtable flakey filters test by billyjacobson · Pull Request #8523 · GoogleCloudPlatform/java-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

docs: fix Bigtable flakey filters test #8523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 9, 2023
Merged

docs: fix Bigtable flakey filters test #8523

merged 2 commits into from
Aug 9, 2023

Conversation

billyjacobson
Copy link
Member
@billyjacobson billyjacobson commented Aug 9, 2023 •
edited
Loading

Description

Updated the table creation to remove any garbage collection. Default for most Bigtable clients is none, but for HBase client it was 1 max version for consistency with HBase API.

Fixes #7963
Fixes #7964
Fixes #7965
Fixes #7966
Fixes #7967

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@billyjacobson billyjacobson requested review from yoshi-approver and a team as code owners August 9, 2023 15:07
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: bigtable Issues related to the Bigtable API. labels Aug 9, 2023
@billyjacobson billyjacobson added the automerge Merge the pull request once unit tests and other checks pass. label Aug 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit e15dfae into main Aug 9, 2023
@gcf-merge-on-green gcf-merge-on-green bot deleted the bt-flakey-filter branch August 9, 2023 19:44
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kweinmeister kweinmeister kweinmeister approved these changes

@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@daniel-sanche daniel-sanche

Labels
api: bigtable Issues related to the Bigtable API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
3 participants
@billyjacobson @kweinmeister @daniel-sanche
0