8000 chore(spanner): remove samples that have moved to the client library by olavloite · Pull Request #5263 · GoogleCloudPlatform/java-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

chore(spanner): remove samples that have moved to the client library #5263

New issue

Have a question about this project? Sign up for a 8000 free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2021
Merged

chore(spanner): remove samples that have moved to the client library #5263

merged 1 commit into from
May 20, 2021

Conversation

olavloite
Copy link
Contributor

The samples for the Google Cloud Spanner client library have been moved to the source repository of the client library. These samples are no longer in use for the documentation, and are also no longer kept up to date and should
be removed.

@olavloite
chore: remove samples that have moved to the client library
2d66e88 
The samples for the Google Cloud Spanner client library have been moved to
the source repository of the client library. These samples are no longer in
use for the documentation, and are also no longer kept up to date and should
be removed.
@olavloite olavloite requested review from thiagotnunes, zoercai and a team May 20, 2021 09:28
@product-auto-label product-auto-label bot added api: spanner Issues related to the Spanner API. samples Issues that are directly related to samples. labels May 20, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 20, 2021
@snippet-bot
Copy link
snippet-bot bot commented May 20, 2021

Here is the summary of changes.

You are about to delete 85 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

thiagotnunes
thiagotnunes approved these changes May 20, 2021
View reviewed changes
Copy link
Contributor
@thiagotnunes thiagotnunes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a nice one +1, -5032 =)

@lesv lesv merged commit f1475a6 into GoogleCloudPlatform:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiagotnunes thiagotnunes thiagotnunes approved these changes

@lesv lesv lesv approved these changes

@kurtisvg kurtisvg kurtisvg approved these changes

@zoercai zoercai Awaiting requested review from zoercai

Assignees

@kurtisvg kurtisvg

Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olavloite @thiagotnunes @lesv @kurtisvg
0