8000 Fixtags by Strykrol · Pull Request #4596 · GoogleCloudPlatform/java-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Fixtags #4596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 26, 2021
Merged

Fixtags #4596

merged 3 commits into from
Jan 26, 2021

Conversation

Strykrol
Copy link
Contributor

Finalizes work from #4542

This is step (3) of (3):

  1. Wrap current region tag with the region tag used in other languages
  2. Update DevSite Java sample to use newer/better region tag
  3. Remove inner 'old' region tag once DevSite changes are proliferated

[ x] Please merge this PR for me once it is approved.

@Strykrol Strykrol requested a review from a team January 25, 2021 20:24
@snippet-bot
Copy link
snippet-bot bot commented Jan 25, 2021 •
edited
Loading

Here is the summary of changes.

You deleted 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 25, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jan 25, 2021
@lesv lesv added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Jan 26, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 305a61d into GoogleCloudPlatform:master Jan 26, 2021
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@lesv lesv

Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Strykrol @lesv @kokoro-team
0