10000 chore: add observability team to codeowners by simonz130 · Pull Request #4012 · GoogleCloudPlatform/java-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

chore: add observability team to codeowners #4012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2020
Merged

chore: add observability team to codeowners #4012

merged 1 commit into from
Oct 15, 2020

Conversation

simonz130
Copy link

cDPE Observability team owns logging and error reporting APIs and samples

Fixes #4011

It's a good idea to open an issue first for discussion.

  • Please merge this PR for me once it is approved.

chore: add observability team to codeowners
d8685ae 
cDPE Observability team owns logging and error reporting APIs and samples
@simonz130 simonz130 requested review from ace-n, czahedi and a team October 15, 2020 04:38
@simonz130 simonz130 self-assigned this Oct 15, 2020
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 15, 2020
@simonz130 simonz130 added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. lang: java Issues specific to Java. api: logging Issues related to the Cloud Logging API. automerge Merge the pull request once unit tests and other checks pass. labels Oct 15, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Oct 15, 2020
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Oct 15, 2020
@lesv lesv merged commit 2e90e03 into master Oct 15, 2020
@lesv lesv deleted the api-logging-codeowners branch October 15, 2020 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

@ace-n ace-n Awaiting requested review from ace-n

@czahedi czahedi Awaiting requested review from czahedi

Assignees

@simonz130 simonz130

Labels
api: logging Issues related to the Cloud Logging API. cla: yes This human has signed the Contributor License Agreement. lang: java Issues specific to Java. priority: p2 Moderately-important priority. Fix may not be included in next release. samples Issues that are directly related to samples. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add cdpe observability team to codeowners of logging
2 participants
@simonz130 @lesv
0