8000 samples: refactor dialogflow for 2.1.0 by munkhuushmgl · Pull Request #3283 · GoogleCloudPlatform/java-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

samples: refactor dialogflow for 2.1.0 #3283

New issue < 8000 div class="d-flex flex-column p-4">

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 30, 2020
Merged

samples: refactor dialogflow for 2.1.0 #3283

merged 6 commits into from
Jun 30, 2020

Conversation

munkhuushmgl
Copy link
Contributor

Fixes #3207

I will refactor IntentMgmt.java and break them down into individual files in different PR.

@munkhuushmgl munkhuushmgl requested a review from a team June 30, 2020 18:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 30, 2020
@munkhuushmgl munkhuushmgl requested a review from lesv June 30, 2020 18:52
lesv
lesv suggested changes Jun 30, 2020
View reviewed changes
Copy link
Contributor
@lesv lesv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider my comments on Exceptions, ok to ignore, but it would be nice if we were more specific so users knew what to expect.

@munkhuushmgl
Copy link
Contributor Author

Consider my comments on Exceptions, ok to ignore, but it would be nice if we were more specific so users knew what to expect.

Will this be sufficient?

  public static KnowledgeBase createKnowledgeBase(String projectId, String displayName)
      throws ApiException, IOException

@munkhuushmgl munkhuushmgl requested a review from lesv June 30, 2020 22:14
@lesv lesv merged commit 90d35c3 into master Jun 30, 2020
@lesv lesv deleted the refactor-dialogflow-samples branch June 30, 2020 22:33
Shabirmean pushed a commit that referenced this pull request Nov 14, 2022
@munkhuushmgl @chingor13
samples: samples: refactor dialogflow for 2.1.0 (#3283)
62de669 
* samples: refactor dialogflow for 2.1.0

* formatted code

* made requested changes

* fixed compilation error

* fixed lint on tests

* lint issue
@Shabirmean Shabirmean mentioned this pull request Nov 15, 2022
Merged
9 tasks
Shabirmean pushed a commit that referenced this pull request Nov 15, 2022
@munkhuushmgl @Shabirmean
samples: samples: refactor dialogflow for 2.1.0 (#3283)
8a2ca6d 
* samples: refactor dialogflow for 2.1.0

* formatted code

* made requested changes

* fixed compilation error

* fixed lint on tests

* lint issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesv lesv lesv approved these changes

Assignees

@averikitsch averikitsch

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dialogflow/cloud-client should be rewritten to support v2
4 participants
@munkhuushmgl @lesv @googlebot @averikitsch
0