-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Merged
Some Trivial Tests #189
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
84 changes: 84 additions & 0 deletions
84
appengine/guestbook-objectify/src/test/java/com/example/guestbook/GreetingTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,84 @@ | ||
/* | ||
* Copyright 2016 Google Inc. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.example.guestbook; | ||
|
||
import static com.example.guestbook.GuestbookTestUtilities.cleanDatastore; | ||
import static org.junit.Assert.assertEquals; | ||
|
||
import com.google.appengine.api.datastore.DatastoreService; | ||
import com.google.appengine.api.datastore.DatastoreServiceFactory; | ||
import com.google.appengine.api.datastore.Entity; | ||
import com.google.appengine.api.datastore.KeyFactory; | ||
import com.google.appengine.api.datastore.PreparedQuery; | ||
import com.google.appengine.api.datastore.Query; | ||
import com.google.appengine.tools.development.testing.LocalDatastoreServiceTestConfig; | ||
import com.google.appengine.tools.development.testing.LocalServiceTestHelper; | ||
|
||
import com.googlecode.objectify.ObjectifyService; | ||
import com.googlecode.objectify.util.Closeable; | ||
import org.junit.After; | ||
import org.junit.Before; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
import org.junit.runners.JUnit4; | ||
|
||
|
||
@RunWith(JUnit4.class) | ||
public class GreetingTest { | ||
private static final String TEST_CONTENT = "The world is Blue today"; | ||
|
||
private final LocalServiceTestHelper helper = | ||
new LocalServiceTestHelper( | ||
// Set no eventual consistency, that way queries return all results. | ||
// https://cloud.google.com/appengine/docs/java/tools/localunittesting#Java_Writing_High_Replication_Datastore_tests | ||
new LocalDatastoreServiceTestConfig() | ||
.setDefaultHighRepJobPolicyUnappliedJobPercentage(0)); | ||
|
||
private Closeable closeable; | ||
private DatastoreService ds; | ||
|
||
@Before | ||
public void setUp() throws Exception { | ||
|
||
helper.setUp(); | ||
ds = DatastoreServiceFactory.getDatastoreService(); | ||
|
||
ObjectifyService.register(Guestbook.class); | ||
ObjectifyService.register(Greeting.class); | ||
|
||
closeable = ObjectifyService.begin(); | ||
|
||
cleanDatastore(ds, "default"); | ||
} | ||
|
||
@After | ||
public void tearDown() { | ||
cleanDatastore(ds, "default"); | ||
helper.tearDown(); | ||
closeable.close(); | ||
} | ||
|
||
@Test | ||
public void createSaveObject() throws Exception { | ||
|
||
Greeting g = new Greeting("default", TEST_CONTENT); | ||
ObjectifyService.ofy().save().entity(g).now(); | ||
|
||
Query query = new Query("Greeting") | ||
.setAncestor(new KeyFactory.Builder("Guestbook", "default").getKey()); | ||
PreparedQuery pq = ds.prepare(query); | ||
Entity greeting = pq.asSingleEntity(); // Should only be one at this point. | ||
assertEquals(greeting.getProperty("content"), TEST_CONTENT); | ||
} | ||
} |
43 changes: 43 additions & 0 deletions
43
...ngine/guestbook-objectify/src/test/java/com/example/guestbook/GuestbookTestUtilities.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,43 @@ | ||
/* | ||
* Copyright 2016 Google Inc. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
package com.example.guestbook; | ||
|
||
import com.google.appengine.api.datastore.DatastoreService; | ||
import com.google.appengine.api.datastore.Entity; | ||
import com.google.appengine.api.datastore.FetchOptions; | ||
import com.google.appengine.api.datastore.Key; | ||
import com.google.appengine.api.datastore.KeyFactory; | ||
import com.google.appengine.api.datastore.PreparedQuery; | ||
import com.google.appengine.api.datastore.Query; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
public class GuestbookTestUtilities { | ||
|
||
public static void cleanDatastore(DatastoreService ds, String book) { | ||
Query query = new Query("Greeting") | ||
.setAncestor(new KeyFactory.Builder("Guestbook", book) | ||
.getKey()).setKeysOnly(); | ||
PreparedQuery pq = ds.prepare(query); | ||
List<Entity> entities = pq.asList(FetchOptions.Builder.withDefaults()); | ||
ArrayList<Key> keys = new ArrayList<>(entities.size()); | ||
|
||
for (Entity e : entities) { | ||
keys.add(e.getKey()); | ||
} | ||
ds.delete(keys); | ||
} | ||
|
||
} |
118 changes: 118 additions & 0 deletions
118
...ine/guestbook-objectify/src/test/java/com/example/guestbook/SignGuestbookServletTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,118 @@ | ||
/* | ||
* Copyright 2015 Google Inc. All Rights Reserved. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package com.example.guestbook; | ||
|
||
import static com.example.guestbook.GuestbookTestUtilities.cleanDatastore; | ||
import static org.junit.Assert.assertEquals; | ||
import static org.mockito.Mockito.when; | ||
|
||
import com.google.appengine.api.datastore.DatastoreService; | ||
import com.google.appengine.api.datastore.DatastoreServiceFactory; | ||
import com.google.appengine.api.datastore.Entity; | ||
import com.google.appengine.api.datastore.KeyFactory; | ||
import com.google.appengine.api.datastore.PreparedQuery; | ||
import com.google.appengine.api.datastore.Query; | ||
import com.google.appengine.tools.development.testing.LocalDatastoreServiceTestConfig; | ||
import com.google.appengine.tools.development.testing.LocalServiceTestHelper; | ||
|
||
import com.googlecode.objectify.ObjectifyService; | ||
import com.googlecode.objectify.util.Closeable; | ||
import org.junit.After; | ||
import org.junit.Before; | ||
import org.junit.Test; | ||
import org.junit.runner.RunWith; | ||
import org.junit.runners.JUnit4; | ||
import org.mockito.Mock; | ||
import org.mockito.MockitoAnnotations; | ||
|
||
import java.io.PrintWriter; | ||
import java.io.StringWriter; | ||
|
||
import javax.servlet.http.HttpServletRequest; | ||
import javax.servlet.http.HttpServletResponse; | ||
|
||
/** | ||
* Unit tests for {@link com.example.guestbook.SignGuestbookServlet}. | ||
*/ | ||
@RunWith(JUnit4.class) | ||
public class SignGuestbookServletTest { | ||
private static final String FAKE_URL = "fakey.org/sign"; | ||
private static final String FAKE_NAME = "Fake"; | ||
|
||
private final LocalServiceTestHelper helper = | ||
new LocalServiceTestHelper( | ||
// Set no eventual consistency, that way queries return all results. | ||
// https://cloud.google.com/appengine/docs/java/tools/localunittesting#Java_Writing_High_Replication_Datastore_tests | ||
new LocalDatastoreServiceTestConfig() | ||
.setDefaultHighRepJobPolicyUnappliedJobPercentage(0)); | ||
|
||
private final String testPhrase = "Noew is the time"; | ||
|
||
@Mock private HttpServletRequest mockRequest; | ||
|
||
@Mock | ||
private HttpServletResponse mockResponse; | ||
|
||
private StringWriter stringWriter; | ||
private SignGuestbookServlet servletUnderTest; | ||
private Closeable closeable; | ||
private DatastoreService ds; | ||
|
||
@Before | ||
public void setUp() throws Exception { | ||
|
||
MockitoAnnotations.initMocks(this); | ||
helper.setUp(); | ||
ds = DatastoreServiceFactory.getDatastoreService(); | ||
|
||
// Set up some fake HTTP requests | ||
when(mockRequest.getRequestURI()).thenReturn(FAKE_URL); | ||
when(mockRequest.getParameter("guestbookName")).thenReturn( "default" ); | ||
when(mockRequest.getParameter("content")).thenReturn( testPhrase ); | ||
|
||
stringWriter = new StringWriter(); | ||
when(mockResponse.getWriter()).thenReturn(new PrintWriter(stringWriter)); | ||
|
||
servletUnderTest = new SignGuestbookServlet(); | ||
|
||
ObjectifyService.register(Guestbook.class); | ||
ObjectifyService.register(Greeting.class); | ||
|
||
closeable = ObjectifyService.begin(); | ||
|
||
cleanDatastore(ds, "default"); | ||
} | ||
|
||
@After public void tearDown() { | ||
cleanDatastore(ds, "default"); | ||
helper.tearDown(); | ||
closeable.close(); | ||
} | ||
|
||
@Test | ||
public void doPost_userNotLoggedIn() throws Exception { | ||
servletUnderTest.doPost(mockRequest, mockResponse); | ||
|
||
Query query = new Query("Greeting") | ||
.setAncestor(new KeyFactory.Builder("Guestbook", "default").getKey()); | ||
PreparedQuery pq = ds.prepare(query); | ||
|
||
Entity greeting = pq.asSingleEntity(); // Should only be one at this point. | ||
assertEquals(greeting.getProperty("content"), testPhrase); | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Trivial Tests #189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account