8000 Update to Truth 1.0 and downgrade to non-beta JUnit by elharo · Pull Request #1763 · GoogleCloudPlatform/java-docs-samples · GitHub
[go: up one dir, main page]
Skip to content

Update to Truth 1.0 and downgrade to non-beta JUnit #1763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 27, 2019
Merged

Update to Truth 1.0 and downgrade to non-beta JUnit #1763

merged 1 commit into from
Nov 27, 2019

Conversation

elharo
Copy link
Contributor
@elharo elharo commented Nov 27, 2019

@elharo elharo requested a review from a team November 27, 2019 18:10
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 27, 2019
@elharo
Copy link
Contributor Author
elharo commented Nov 27, 2019

Failures do not appear related:

------------------------------------------------------------
- testing kms
------------------------------------------------------------
[ERROR] src/main/java/com/example/Asymmetric.java:[120] (naming) AbbreviationAsWordInName: Abbreviation in name 'decryptRSA' must contain no more than '2' consecutive capital letters.
[ERROR] src/main/java/com/example/Asymmetric.java:[138] (naming) AbbreviationAsWordInName: Abbreviation in name 'encryptRSA' must contain no more than '2' consecutive capital letters.
[ERROR] src/main/java/com/example/Asymmetric.java:[200] (naming) AbbreviationAsWordInName: Abbreviation in name 'verifySignatureRSA' must contain no more than '2' consecutive capital letters.
[ERROR] src/test/java/com/example/AsymmetricIT.java:[135] (naming) AbbreviationAsWordInName: Abbreviation in name 'testRSAEncryptDecrypt' must contain no more than '2' consecutive capital letters.
[ERROR] src/test/java/com/example/AsymmetricIT.java:[144] (naming) AbbreviationAsWordInName: Abbreviation in name 'testRSASignVerify' must contain no more than '2' consecutive capital letters.
[ERROR] src/test/java/com/example/AsymmetricIT.java:[156] (naming) AbbreviationAsWordInName: Abbreviation in name 'testECSignVerify' must contain no more than '2' consecutive capital letters.
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:3.0.0:check (default) on project kms-samples: You have 6 Checkstyle violations. -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException

 Testing failed: Maven returned a non-zero exit code.

This is one example of why I don't like checkstyle presubmit checks on Github.

@kurtisvg
Copy link
Contributor

This is one example of why I don't like checkstyle presubmit checks on Github.

The check is there for a reason, the problem is that it was somehow submitted in a broken state to begin with.

@kurtisvg kurtisvg mentioned this pull request Nov 27, 2019
Closed
@kurtisvg kurtisvg merged commit 56cab68 into GoogleCloudPlatform:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elharo @kurtisvg @googlebot
0