Model optimizer #10086
Model optimizer #10086
Conversation
There was a problem hiding this comment.
Hello @nardosalemu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request introduces a new module genai with samples demonstrating how to use model routing with the Gemini API. It includes code snippets for generating content and streaming content, along with corresponding integration tests. Additionally, it updates the storage-transfer module's pom.xml file.
Highlights
- New Module: genai: A new module named
genaiis added, containing code samples for using the Gemini API with model routing. - GenerateContentWithRouting: Introduces a sample for generating content with routing, showcasing how to specify model selection preferences.
- StreamGenerateContentWithRouting: Adds a sample for streaming content generation with routing, demonstrating how to handle responses as a stream.
- Integration Tests: Includes integration tests for both content generation and streaming samples to ensure proper functionality.
- Storage Transfer POM Update: Updates the
storage-transfermodule'spom.xmlfile with dependency management and test dependencies.
Changelog
Click here to see the changelog
- genai/pom.xml
- Added a new pom file for the genai module.
- Configured dependencies for google-genai and testing libraries (JUnit, Truth).
- genai/src/main/java/genai/GenerateContentWithRouting.java
- Created a new class to demonstrate content generation with model routing.
- Uses ModelSelectionConfig to specify feature selection preferences.
- Uses Client builder to set http options and enable Vertex AI.
- Implements a GenerateContent method that calls the Gemini API and returns the response text.
- genai/src/main/java/genai/StreamGenerateContentWithRouting.java
- Created a new class to demonstrate streaming content generation with model routing.
- Uses ModelSelectionConfig to specify feature selection preferences.
- Uses Client builder to set http options and enable Vertex AI.
- Implements a GenerateContentStream method that calls the Gemini API and returns the response stream as text.
- genai/src/test/java/genai/GenerateContentWithRoutingIT.java
- Created an integration test for GenerateContentWithRouting.
- Verifies that the generated content is not empty.
- Checks for required environment variables (GOOGLE_APPLICATION_CREDENTIALS, GOOGLE_CLOUD_PROJECT).
- genai/src/test/java/genai/StreamGenerateContentWithRoutingIT.java
- Created an integration test for StreamGenerateContentWithRouting.
- Verifies that the streamed content is not empty.
- Checks for required environment variables (GOOGLE_APPLICATION_CREDENTIALS, GOOGLE_CLOUD_PROJECT).
- storage-transfer/bin/pom.xml
- Updated dependency versions.
- Added test dependencies (aws-java-sdk-s3, aws-java-sdk-sqs, azure-storage-blob).
- Added slf4j dependencies.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A model's the heart,
Routing guides its smart,
GenAI's new art.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces new samples for the GenAI API, demonstrating content generation with routing capabilities. It also includes updates to the storage transfer sample's POM file. Overall, the code is well-structured and includes necessary dependencies and tests. However, there are a few areas that could be improved for clarity and maintainability.
Summary of Findings
- Copyright Year: The copyright year in the new files is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
- TODO Comments: The
GenerateContentWithRouting.javaandStreamGenerateContentWithRouting.javafiles containTODOcomments for replacing variables. Consider providing default values or instructions on how to obtain these values to make the samples more runnable out-of-the-box. - Dependency Versions: The
storage-transfer/bin/pom.xmlfile uses an older version ofmaven.compiler.targetandmaven.compiler.source. Consider updating these to a more recent version, such as 11, to align with the other POM file and leverage newer language features.
Merge Readiness
The pull request is almost ready for merging. Before merging, please address the copyright year and TODO comments. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. Addressing the comments will improve the overall quality and usability of the samples.
| @@ -0,0 +1,61 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,68 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,69 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
| @@ -0,0 +1,69 @@ | |||
| /* | |||
| * Copyright 2025 Google LLC | |||
There was a problem hiding this comment.
The copyright year is set to 2025. Please confirm that this is the correct year, or update it to the current year if appropriate.
d31606a to
74e5607
Compare
74e5607 to
bbaeb8d
Compare
Description
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only