This repository was archived by the owner on May 16, 2025. It is now read-only.
Correctly check for .NET Core before creating config files.#818
Merged
ivannaranjo merged 2 commits intoGoogleCloudPlatform:masterfrom Oct 3, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #818 +/- ##
=======================================
Coverage 11.84% 11.84%
=======================================
Files 504 505 +1
Lines 12323 12323
=======================================
Hits 1460 1460
Misses 10863 10863
Continue to review full report at Codecov.
|
ILMTitan
suggested changes
Oct 2, 2017
| public static bool IsAspNetCoreProject(this IParsedProject project) | ||
| => project.ProjectType == KnownProjectTypes.NetCoreWebApplication1_0 || | ||
| project.ProjectType == KnownProjectTypes.NetCoreWebApplication1_1 || | ||
| project.ProjectType == KnownProjectTypes.NetCoreWebApplication2_0; |
There was a problem hiding this comment.
Create unit tests for this function? There should be 6 (null project, null ProjectType, invalid ProjectType, and the 3 success cases).
Contributor
Author
There was a problem hiding this comment.
This function is trivial, the tests are really unnecessary since they will just duplicate the function itself. There's really no logic.
ILMTitan
approved these changes
Oct 3, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the right check to enable/disable the menu item for creating config files to ASP.NET Core apps. The check has been centralized into an extension method so it can be used anywhere we need to check for the ASP.NET Core framework, like the publishing wizard.
Fixed #816