8000 chore: use Release Please app for releases by anniefu · Pull Request #182 · GoogleCloudPlatform/functions-framework-python · GitHub
[go: up one dir, main page]

Skip to content

chore: use Release Please app for releases #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2022

Conversation

anniefu
Copy link
Contributor
@anniefu anniefu commented Apr 29, 2022

This also handles bumping the version number in setup.py so that a separate
PR doesn't need to made.

When the GitHub Release is published by the Release Please app, it will
kick off the "Release to PyPI" Workflow.

This also handles bumping the version number in `setup.py` so that a separate
PR doesn't need to made.

When the GitHub Release is published by the Release Please app, it will
kick off the "Release to PyPI" Workflow.
@anniefu anniefu requested review from asriniva and grant April 29, 2022 15:50
Copy link
Contributor
@grant grant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will handle GitHub releases, but PyPI releases will be done through:

https://github.com/GoogleCloudPlatform/functions-framework-python/blob/master/.github/workflows/release.yml

@anniefu
Copy link
Contributor Author
anniefu commented Apr 29, 2022

Yep, that's mentioned in the PR description.

@anniefu anniefu merged commit 0a7937c into GoogleCloudPlatform:master Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0