feat: Add more details to MissingTargetException error #158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaylaNguyen
reviewed
Dec 28, 2021
| @@ -256,9 +256,15 @@ def handle_none(rv): | |||
|
|
|||
| # Extract the target function from the source file | |||
| if not hasattr(source_module, target): | |||
There was a problem hiding this comment.
Would you mind syncing this PR to main branch? This line should now be in _function_registry.py.
There was a problem hiding this comment.
@KaylaNguyen I'm not a maintainer of this repo anymore, and thus don't have write access to this branch.
There was a problem hiding this comment.
Hi Dustin, would you mind forking this repo and copy this branch to a new one on di/functions-framework-python and create a PR from that instead? Then you won't need to be a maintainer of the repo to make changes to the branch. We can add you as maintainer of this repo to proceed with these 2 commits but all admins are OOO atm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include names of other functions found in the file. This will help debug issues like #157.